Comments (12)
Hey Daniel thanks for doing this and keep in mind I can help with the grunt work, now that you explained the problem I can apply the exclusions...
Oh ...if you found that's even better 😁
from clojure-maven-plugin.
The change is indeed trivial. The problem is that the test is breaking, and the reason for that is rather involved and related to how the integration tests are run. I can see that tools.nrepl is present on the classpath despite explicitly pulling nrepl/nrepl. I suspect a transitive dependency is pulling it in. I am currently trying to hunt it down. Wish me luck.
from clojure-maven-plugin.
OK, I found the problem. I'll do a PR as soon as I'm done.
from clojure-maven-plugin.
Thank you, Andrea.
from clojure-maven-plugin.
@danielsz awesome! Will pull this in shortly ( probably tonight and release ).
from clojure-maven-plugin.
@talios Thank you! I love this project.
from clojure-maven-plugin.
Ahh - I see the commit message didn't mention the ticket so didn't auto-close. Manually doing so :)
from clojure-maven-plugin.
I updated the README to mention the new maven dependency/version - are all the arguments/system properties still valid?
from clojure-maven-plugin.
Yes, arguments/properties should be exactly as before, Thank you for updating the README with the new nREPL dependency/version. I forgot to do that myself. Sorry about that.
from clojure-maven-plugin.
...and released - should be in central within the hour.
from clojure-maven-plugin.
Awesome I was exactly trying to fetch it 😉
from clojure-maven-plugin.
@arichiardi if needed - you could probably resolve it from the oss.sonatype.org repositories directly - or just wait a bit longer :)
from clojure-maven-plugin.
Related Issues (20)
- Add support for direct linking ( 1.8 clojure required )
- 1.8.1 is not in Maven Central HOT 3
- Plugin picks up all files in the source/test folders
- Cannot build the plugin
- Transpile .cljc files to .clj HOT 1
- AOT compilation order is not predictable HOT 1
- Not able to generate test output with junit xml format
- compiler mojo does not respect JAVA_HOME when searching for executable HOT 3
- what does the `it` directory do? HOT 2
- Key must be integer with new nrepl and cider middleware HOT 8
- nREPL support , missing edge case HOT 1
- NamespaceDiscovery.findNamespaceInFile String index out of range HOT 1
- Incorrect test summary with clojure >= 1.7.0-alpha6
- Request for a sample pom.xml that shows how to use this plugin with SpringBoot HOT 3
- Is it possible to run a single Clojure test namespace?
- All dependencies get packaged into jar HOT 8
- Maven seems to compile with wrong version of Clojure
- Plugin Not Running When Java Test Fails HOT 5
- ClojureScript tests? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clojure-maven-plugin.