Giter VIP home page Giter VIP logo

Comments (12)

arichiardi avatar arichiardi commented on September 28, 2024 1

Hey Daniel thanks for doing this and keep in mind I can help with the grunt work, now that you explained the problem I can apply the exclusions...

Oh ...if you found that's even better 😁

from clojure-maven-plugin.

danielsz avatar danielsz commented on September 28, 2024

The change is indeed trivial. The problem is that the test is breaking, and the reason for that is rather involved and related to how the integration tests are run. I can see that tools.nrepl is present on the classpath despite explicitly pulling nrepl/nrepl. I suspect a transitive dependency is pulling it in. I am currently trying to hunt it down. Wish me luck.

from clojure-maven-plugin.

danielsz avatar danielsz commented on September 28, 2024

OK, I found the problem. I'll do a PR as soon as I'm done.

from clojure-maven-plugin.

danielsz avatar danielsz commented on September 28, 2024

Thank you, Andrea.

#114

from clojure-maven-plugin.

talios avatar talios commented on September 28, 2024

@danielsz awesome! Will pull this in shortly ( probably tonight and release ).

from clojure-maven-plugin.

danielsz avatar danielsz commented on September 28, 2024

@talios Thank you! I love this project.

from clojure-maven-plugin.

talios avatar talios commented on September 28, 2024

Ahh - I see the commit message didn't mention the ticket so didn't auto-close. Manually doing so :)

from clojure-maven-plugin.

talios avatar talios commented on September 28, 2024

I updated the README to mention the new maven dependency/version - are all the arguments/system properties still valid?

from clojure-maven-plugin.

danielsz avatar danielsz commented on September 28, 2024

Yes, arguments/properties should be exactly as before, Thank you for updating the README with the new nREPL dependency/version. I forgot to do that myself. Sorry about that.

from clojure-maven-plugin.

talios avatar talios commented on September 28, 2024

...and released - should be in central within the hour.

from clojure-maven-plugin.

arichiardi avatar arichiardi commented on September 28, 2024

Awesome I was exactly trying to fetch it 😉

from clojure-maven-plugin.

talios avatar talios commented on September 28, 2024

@arichiardi if needed - you could probably resolve it from the oss.sonatype.org repositories directly - or just wait a bit longer :)

from clojure-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.