Key must be integer with new nrepl and cider middleware about clojure-maven-plugin HOT 8 CLOSED

It looks like the plugin does not know how to handle a vector of middleware symbols, which is what cider.nrepl/cider-middleware ends up being.

from clojure-maven-plugin.

Ok yes closing.

from clojure-maven-plugin.

@arichiardi 😊 ☺️ Awesome!

Yes, the README needs some love, for sure. I could do a PR after the weekend.

@talios In my opinion, not a problem, a README update is enough. Kind of interesting to contemplate the fact of authoring a wrapper to the Clojure compiler but then not using it much. Life is unpredictable, isn't it?! At any rate, thank you for your work, it's awesome. I have and still am benefiting from your efforts. 🙏

from clojure-maven-plugin.

I was wondering: have you tried configuring the cider handler instead?

From the Cider manual:

(ns my-app
  (:require [nrepl.server :as nrepl-server]
            [cider.nrepl :refer (cider-nrepl-handler)]))

(defn -main
  []
  (nrepl-server/start-server :port 7888 :handler cider-nrepl-handler))

I suppose that translates to something like that:

<build>
          <plugins>
            <plugin>
              <groupId>com.theoryinpractise</groupId>
              <artifactId>clojure-maven-plugin</artifactId>
              <version>1.8.4</version>
              <extensions>true</extensions>
              <configuration>
                <nreplHandler>
                 cider.nrepl/cider-nrepl-handler
                </nreplHandler>
              </configuration>
            </plugin>
          </plugins>
        </build>

from clojure-maven-plugin.

Can we close this? I think the above is the recommended way forward with regards to Cider.

from clojure-maven-plugin.

Thanks, I feel like I should explain just a little bit more:

cider.nrepl/cider-middleware itself is not middleware. It is a vector that contains all Cider's middleware. It is a convenience used by Leiningen and Boot because it facilitates end-user configuration. In our case, we configure nREPL with the cider handler, which handles that for us:

(def cider-nrepl-handler
  "CIDER's nREPL handler."
  (apply nrepl-server/default-handler (map resolve-or-fail cider-middleware)))

Sorry if I rushed things a little bit. Maybe I shouldn't have.

from clojure-maven-plugin.

@danielsz so is this actually a problem? Or maybe something just needed a README update? ( I don't use nrepl or cider, or - actually actively use clojure beyond some libs our other teams use ).

from clojure-maven-plugin.

No problem @danielsz! You did not rush it 😄

For sure it is something we can add to the README, because it kind of gives different directions compared to what the current cider manual gives. It is also a newer addition to the cider.nrepl namespace and indeed quite convenient 😸

from clojure-maven-plugin.