tim-actions / dco Goto Github PK

Since DCO check lives in automated processes, it is especially painful when it fails in a situation that it shouldn't have. This can happen when someone changes their github name or their github email. To allow for that change to happen more smoothly, it could be better to check only one or the other. I think it still ticks the box that DCO is trying to tick, but it ticks it in a nicer way that allows for these kinds of changes without triggering unnecessary integration failures.

Currently the user "only" receives

when not all commits are signed-off.

That is good information on what the user should do the next time when contributing to the repo. But it doesn't help much to fix the current PR. Since I am only/still a beginner at git I have no good suggestion myself, but had seen

git remote update
git rebase --exec 'git commit --amend --no-edit -n -s' @{upstream}

in this comment. Assuming that this advice is useful, would it be worth to adapt helper.js accordingly?

Let's add some tests!

Currently the project has node_modules checked in. There should be a build process that produces a release that can be used by projects that npm installs, remove node_modules from the tree.

First, thank you for your work to create these useful actions!

I wonder if it would be possible to make updated releases for your tim-actions/get-pr-commits, tim-actions/dco, and tim-actions/wip-check GitHub Actions? I prefer to stick to released versions to avoid possible breakages on master (per GitHub guidelines), but would like to get the latest commits (version bumps and such).

When I use the suggested YAML to configure this I get:

Unexpected input 'token', valid inputs are ['commits']

If I replace:

with:
  token: ${{ secrets.GITHUB_TOKEN }}

with instead:

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Then I get:

Unexpected end of JSON input