tomvanenckevort / nopcommerce.htmloptimiser Goto Github PK

Are there any plans to upgrade the plugin for the newer version of NopCommerce? Current version of plugin doesn't seem to work with NopCommerce 3.8.

Can you please tell me if I'm doing smth wrong or should some changes be made to the plugin? Thank you!

Text files (like robots.txt) are currently being minified, but probably should be excluded.

The WebMarkupMin library is currently set to minify everything (remove comments, quotes, etc.).
All these options can be configured as well, and therefore it would be good to have configuration options in the plugin screen where users can set which minification options they would like to use.

Reported by a user: in certain cases the minification concatenates the HTML attribute to the tag, breaking the overall page layout.

Example:

<div
      id="test"></div>

gets minified to:

<divid="test"></div>

An intermittent error that appears in the logs was reported by a user:

System.IndexOutOfRangeException: Probable I/O race condition detected while copying memory. 
The I/O package is not thread safe by default. In multithreaded applications, a stream 
must be accessed in a thread-safe way, such as a thread-safe wrapper returned by 
TextReader's or TextWriter's Synchronized methods. This also applies to classes like 
StreamWriter and StreamReader. at System.Buffer.InternalBlockCopy(Array src, Int32 
srcOffsetBytes, Array dst, Int32 dstOffsetBytes, Int32 byteCount) at 
System.IO.MemoryStream.ToArray() at Nop.Plugin.Misc.HtmlOptimiser.Code.WhitespaceFilter.Flush()

Reported by a user: the HTML minification also gets applied to XML output (for example the sitemap) and strips out too many characters (mainly quotes) which causes the XML to be invalid:

<urlset xmlns=http://www.sitemaps.org/schemas/sitemap/0.9 
  xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance 
  xsi:schemalocation=http://www.sitemaps.org/schemas/sitemap/0.9 
  http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd>
  <url>
    <loc>http://localhost:15536/</loc>
    <changefreq>weekly</changefreq>
    <lastmod>2014-08-17</lastmod>
  </url>  
</urlset>

Reported by a user: when using Unicode characters (like letters with accents) it displays them as a '?'.

Most probably because the stream filter uses the system default encoding type, which might be ASCII. Should force it to UTF-8 instead.