Comments (8)
@alexbw as I said, I am okay with either. I think we should give the one a try, i.e. keeping submodules at fixed commits. If we have any issues, we would uncover them as we go.
Historically, I built torch-distro for @jonathantompson, as he was complaining that he missed the old torch7-distro, and with torch7-distro, we just had one giant repo of everything (which was automatically on master by definition). But torch-distro has gotten bigger than that one single use-case.
Also, it's great that you are taking the lead on this, dont tone it down at all :)
from distro.
This is a great initiative. I'd vote for versioning commits, and upgrade them only when certain strict conditions are met (such as travis giving you the green light). It's especially important for /torch7, /nn, /cutorch and /cunn, where any subtle regression becomes a huge pain to trace.
from distro.
on board with that idea as well.
on the issue of travis, we have travis for torch7 and nn, but it almost always fails when running the unit tests, by just not responding for a long time. It seems to be a bug of VM + OpenBlas.
We also do not have travis testing for cutorch/cunn
If you guys have any ideas, let me know
from distro.
So about openblas, I think we should kill it for travis (if not everywhere...). This would speedup the build tremendously. What do you think?
For CUDA stuff, it's tricky to test for sure (no gpus on travis right?). Maybe we could host some of this testing somewhere else.
from distro.
Ok. I will remove the line in install.sh that automatically pulls all new repos and update all submodules to their current master
branches.
After that, all new cool updates to included submodules have to be rolled in via a git submodule commit update. I think this is feasible, because if this distribution becomes a community standard, folks will pester us with github issues when it's time to update. I like the push better than pull model here :)
from distro.
Totally agreed!
from distro.
👍
from distro.
Done in dbf367a
. Tested on laptop.
from distro.
Related Issues (20)
- macOS - Lua2.1 - File not found lua-cjson-2.1devel-1.rockspec HOT 2
- Error occur when execute install.bat
- error installing torch 7 on fedora 29
- OpenSuSE install-deps outdated
- Error: File not found: lua-cjson-2.1devel-1.rockspec HOT 3
- Install script causes `$LD_LIBRARY_PATH` to include `cwd`. HOT 1
- Update wineditline version
- Install on debian 10 HOT 1
- cublas runtime error : the GPU program failed to execute at /root/torch/extra/cutorch/lib/THC/THCBlas.cu:246
- Segmentation Fault while loading torch HOT 1
- invalid option: --with-wxmac when installing bash install-deps HOT 4
- install.bat freezes on Windows 10 HOT 4
- ./install.sh -> Configuring incomplete, errors occurred! HOT 2
- No results matching query were found. HOT 1
- Ubuntu 20.04 HOT 6
- bash insatll-deps does not work on ubuntu. bash: install-deps: No such file or directoryu
- pip install pytorch HOT 1
- CUDA_cublas_device_LIBRARY (ADVANCED)
- Installing torch on Ubuntu 20.04?
- ./install.sh fails in Mac OS Monterey 12.5 ( M1 Pro ) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from distro.