Giter VIP home page Giter VIP logo

Comments (4)

plivesey avatar plivesey commented on September 28, 2024

This comment also highlights the same issue:

line 270, TMDiskCache.h
Retrieves the file URL for the specified key. This method blocks the calling thread until the
url is available. Do not use this URL anywhere but on the . This method probably
shouldn't even exist, just use the asynchronous one.

from tmcache.

plivesey avatar plivesey commented on September 28, 2024

The first comment is from line 183 in TMDishCache.h

from tmcache.

jstn avatar jstn commented on September 28, 2024

The file manager itself can probably deal with reads just fine, but the intention is to maintain cache consistency. We don't want another thread moving or changing a file when there's already a block queued up that will need it. There's also the issue of file sizes and dates being changed on disk without the cache having a chance to update its own metadata.

It's also a performance consideration. 10 different caches shouldn't read 10 files in parallel off the disk, serial is a better approach here (hence the shared queue across caches.) A nice side effect of this is that two instances of TMDiskCache can use the same disk area without conflict.

from tmcache.

plivesey avatar plivesey commented on September 28, 2024

I didn't notice that the disk queue was serial, but that makes a lot of sense and answers some of my other questions on how reliable GCD is for not overloading the disk. Having a shared queue definitely makes sense for this, and it also makes sense that other threads should not use the fileUrl for any reason.
Thanks for your help. Since my questions were answered, I'm going to close the issue.

from tmcache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.