Comments (3)
Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).
To address the issue with special characters such as '+' breaking the table view when used as a filter, you'll need to modify the isMatchingStringFilter
function in /packages/twenty-front/src/modules/object-record/record-filter/utils/isMatchingStringFilter.ts
. Specifically, for the like
and ilike
cases, where the input string is converted into a regex pattern, you should escape special regex characters to ensure they are treated as literals. Here's a suggested change for the like
and ilike
cases: javascript case stringFilter.like !== undefined: { const escapedPattern = stringFilter.like.replace(/[.*+?^${}()|[\]\]/g, '\\$&'); // Escapes special characters const regexPattern = escapedPattern.replace(/%/g, '.*'); const regexCaseSensitive = new RegExp(`^${regexPattern}$`); return regexCaseSensitive.test(value); } case stringFilter.ilike !== undefined: { const escapedPattern = stringFilter.ilike.replace(/[.*+?^${}()|[\]\]/g, '\\$&'); // Escapes special characters const regexPattern = escapedPattern.replace(/%/g, '.*'); const regexCaseInsensitive = new RegExp(`^${regexPattern}$`, 'i'); return regexCaseInsensitive.test(value); }
This change adds a step to escape special regex characters in the like
and ilike
string filters before converting the '%' wildcard characters into '.*' for regex matching. This should allow special characters such as '+' to be used in filters without breaking the table view.
References
/packages/twenty-front/src/modules/object-record/record-filter/utils/isMatchingStringFilter.ts
from twenty.
It didn't got error but unexpected behaviour.
Screencast from 2024-05-29 18-08-31.webm
Edit: It's working now without any change. idk why it was not working before.
Screencast from 2024-05-29 21-03-44.webm
from twenty.
Thanks @suman-somu! I'm also unable to reproduce the issue so I will close this, it has probably been fixed...
from twenty.
Related Issues (20)
- Error when displaying message threads with a large number of participants
- Whitescreen when user not found HOT 5
- Custom fields lacks empty tag HOT 3
- Invite by email table overflows in mobile viewport HOT 5
- [Worklfow][Timebox] Prevent updates in tables
- Ex: `additionalEmails` spec'd as object(key value pair) in PATCH, POST in the API documentation HOT 2
- Email Participants Dropdown HOT 4
- Clicking Enter selects the first field in custom Select fields
- Cursor should not be "pointer" when record image identifier is not editable
- SMTP not working on self-hosted instance
- Use `<label>` HTML element for input labels
- `Notes` and `Tasks` icons size issue
- Timeline Feed: Exclude Empty Record Creation/Deletion Logs
- View is not always updated after performing actions in the serverless function and workflow pages
- Adjust Floating Input Padding and Border Color
- Relation picker UX improvements HOT 2
- Add Header to Email & Calendar Tabs HOT 2
- Cursor pointer on Settings cards HOT 1
- The width of the checkbox column varies based on the width of other columns
- Whatsapp Business sync
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twenty.