Archive vs Recent blogs and meetups about ourumbraco HOT 3 CLOSED

1. Navigation: should be fine for now to just list all blogs/meetup groups in the menu I think, we can rework it once the list gets too long
2. Removal: I think removal would be super rare, don't need to be concerned about that for now
3. Old posts: Not sure, let's start with what data we have now and can get in the future, if people want to include more archives they could update their RSS generator or have a separate one for a while to offer archived posts - if we start with what we have now we'll still have a 2 year archive in 2 years

from ourumbraco.

I've been playing a bit around with this one. The IDs of the various blogs don't use the same format. They're all GUIDs, but some are lowercase, some are uppercase and a few are enclosed in curly brackets:

https://github.com/umbraco/OurUmbraco/blob/master/OurUmbraco.Site/config/CommunityBlogs.json

I think it would be best to use the same format - it looks better, and may also have some advantages when we're storing and comparing GUID-like strings in the database.

So should we fix this in the JSON file, or correct this with code?

Something like:

private BlogInfo(JObject obj) {

    Id = obj.GetString("id");
    Title = obj.GetString("title");
    Url = obj.GetString("url");
    RssUrl = obj.GetString("rss");
    LogoUrl = obj.GetString("logo");
    MemberId = obj.GetInt32("memberId");
    CheckTitles = obj.GetBoolean("checkTitles");
    Encoding = Encoding.UTF8;

    // Attempt to correct the format of the ID (becomes a lowercase GUID)
    Guid guid;
    if (!Guid.TryParse(Id, out guid)) throw new Exception("Invalid GUID for blog " + Title);
    Id = guid.ToString();

}

Or even change the Id property to Guid instead of string:

private BlogInfo(JObject obj) {
    Id = obj.GetString("id", Guid.Parse);
    Title = obj.GetString("title");
    Url = obj.GetString("url");
    RssUrl = obj.GetString("rss");
    LogoUrl = obj.GetString("logo");
    MemberId = obj.GetInt32("memberId");
    CheckTitles = obj.GetBoolean("checkTitles");
    Encoding = Encoding.UTF8;
}

If we then later convert the ID back to a string, it will have a format as 12f4440a-c87b-4450-964a-d4ea50fae18c - that is: lowercase and not enclosed.

from ourumbraco.

Hiya @abjerner,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version 8.9.0

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

from ourumbraco.