Giter VIP home page Giter VIP logo

universale's People

Contributors

finbargiusti avatar immohsin avatar sdthapar avatar shubham617 avatar vedantpuri avatar zhuyifan avatar zkiihne avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

universale's Issues

Rendering

  • Way to display the correct number of stars in user profile
  • Option/Button to flag an item onuser page
  • Avoid reuse of navbar and footer code, try to incorporate using an include/ add it to base.html
  • Revise UML diagram

Edit Profile

  • Add edit profile button in profile_view
  • Link it to the edit_profile_view

Footer consistency

Make footers consistent:

-Contact Details
-Copyright
-Back-to-top [optional]

Upload product form [django]

  • Add image field
  • Set min_length of item name to 10.
  • Complete overall styling to make it look like earlier in terms of style
  • Make required fields show a red asterisk
  • Study about how to send data to the server once the user hits submit
  • Show pop-up to notify user that product uploaded successfully

General Tips

  • Caching is a serious issue we face while developing, Hence before ensuring that your view is incorrect and is having styling bugs and wasting endless hours on the internet looking for the solution, make sure you all clear the cache and reload the page once to check. Could also test the page in a different browser/ incognito mode.
  • During this time we would be testing our forms alot by trying to create/ update objects. Make sure you don't add the db.sqlite file while performing a commit as that may cause a mishap for other teammates.
  • Stemming from the previous issue, ensure none of the media files you upload locally using django forms are committed to the repo as these redundancies increase the size of the app drastically.

Rentals

Could add the feature of renting stuff through the app

Consistency

Make navbar and footer consistent throughout all pages.

Use the ecommerce link, or the product page's navbar.

Registration Link

  • No registration page implemented in django
  • Once done, uncomment the line linking login.html to registration page

Search

Search of flagged items

Incoherency in search and flagged

Your item views are inconsistent with each other, one shows stars and view item whereas the other does not. Fix it using:-

  • Both show just view item and flag item button
  • Both remove stars
  • Both remove stats on number of viewed and number of flagged

Nav bar

  • Link the search button to our search view
  • Add login/ register html and css files to templates
  • Link the sign in/ register button to the login view
  • Small styling inconsistencies amongst nav-bar on separate pages

Future Capabilities

  • Unflag Items
  • Delete Product
  • View Seller
  • Getting rid of redundancies
  • Create Contributing.MD
  • Create Issue template, PR template and Code of Conduct
  • Improve README
  • Proper code styling
  • Implement pagination to limit only a certain number of results per page
  • Allow users to star other users.(Back-end)
  • Calculating User Star Count
  • Improve Overall Styling (Front-end)
  • Generalize search queries (Implement a proper search with auto-suggest etc)
  • User Reviews

Profile Edit Page

Create form to allow the user to edit their profile

Note: should be the same template as profile view page

Add unit tests for the projects.

Is your feature request related to a problem? Please describe.
When merging a new pr, there are chances that it can break something in the master branch. To be safe add unit tests for every component that will run against some predefined tests.

Additional context
Use the django testing framework for writing tests on views.

Ambiguity in user model

  • Resolve ambiguity between django user model and custom user model by modifying the name of the custom user class.
  • Make migrations to confirm the change.

nav links

Tabs on navbars should redirect to the correct page

Responsiveness

Describe the bug
Various elements get distorted on different screen sizes and should stay uniform

To Reproduce
Steps to reproduce the behavior:

  1. Open the local host on a larger monitor (21:9)
  2. View footer on separate pages

Expected behavior
The view should be similar on all screens irrespective of the size

Specifications (please complete the following information):

  • OS: macOS 10.13.6
  • Browser: Safari
  • Monitor : LG UltraWide 29"

User Mapping

Create new django users using the ADMIN site with descriptive details and passwords, and map them appropriately to our custom user (should be one-to-one).

Make sure to assign them to the User Base Group

Logo

Need a logo for our app

Logo proposal to UNIVERSALE

Hi, I'm a graphic designer and I like to collaborate with open source projects. I was seeing and I found this issues. I would like to design a logo for your Project. I will be happy to collaborate with you :)

Flagged item search

Is your feature request related to a problem? Please describe.
Currently no way to search items in my flagged list.

Describe the solution you'd like
Implement such a search mechanism. Search bar exists, just need to implement back-end

Pagination

Implement pagination for various pages (Flagged and Search)

Colleges should be configurable

Problem
As OSS, it is standard to de-localize the software. I understand the purpose of universale is to serve 5 colleges, and that shouldn't change, but for those forking this project or running it for colleges in their area, college options and others should be easily modifiable.

Solution
An object should be added to Django/universale/settings that would be referenced when building the user forms. Also, to support longer lists of universities, a search dropdown system should be added. (example)

I could work on this, however I'm busy the next few days (curr. on holidays in Mexico) so if someone gets there before me, that would benefit universale.

Thanks for reading and good luck ๐Ÿ˜ƒ

Search View

All the following points refer to the screenshot at the bottom:

  • Restore the original search icon next to the search input field [blue button]
  • Make the search result page title dynamic. As seen in the screenshot, it always displays the title as Search Result: Textbook even if I didn't search for textbook.
  • Show what the user searched as a placeholder in the search input field once the results are displayed in search view
  • Make a placeholder text saying "No items matched your search", if no products were found and display that in the view using a simple if condition checking if there were any products in the query-set or not.
  • Modify only the search result page css so as to make the footer always stay at the bottom of the page regardless of the number of search results.

screen shot 2018-04-14 at 12 07 13 pm

Logout page

Create logout page to be redirected to once a user hits logout.
Some design considerations :

  • Try to mimic login page theme
  • Replace login container with a message saying "You were Logged out successfully !"
  • Place a link to the GitHub repo at the bottom just like in login
  • A button to redirect them back saying "Log Back in again"

Profile view page theme

Modify profile view page to immerse in overall theme.

Use photography portfolio template.

Styling issues

  • Remove redundant search in nav bar on landing page
  • Shift edit profile button from nav bar to somewhere in the User Profile view
  • Temporarily get rid of Log Out button [Will be added later on when authentication is implemented]

Testing Mechanism

Is your feature request related to a problem? Please describe.
Currently no automated testing mechanism to check any code breaks.

Describe the solution you'd like
Need mechanism to test input values and maybe test users and products to test various functionality.

Logout Facility

  • Add logout button to nav bar [Visible only if user is authenticated]
  • Create logout html and style it appropriately

User Profile Picture file not sanitized

Describe the bug
When a user adds a non-image file as there profile picture on signup, an error is not returned and the file is hosted. This can be exploited to use this service to freely host files.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to sign up page
  2. Attempt to upload non-image file as profile picture

Expected behavior
A frontend error should occur prior to posting and the backend, for security reasons should be able to sanitize/ignore rogue POSTs anyways.

For the record, I am currently working on a solution with my decent but not perfect knowledge of Python, coming to a pull request near you! - ๐Ÿ˜„

It is important to start thinking about payment systems.

The Problem

I have worked on a few payment systems so far and I can say that marketplace transaction systems are both difficult to program and potentially expensive. As FOSS, we obviously can not go for an enterprise solution, however I believe it's important to start prototyping solutions.

My Idea

I was thinking that as an option on signup or when editing a profile, a person would add their PayPal.me account. This would then allow people to purchase by direct PayPal transactions through the payment widget.

Suggest More

My idea was quite rudimentary so it wouldn't be too hard to make a better one. Please reply and if the owner see this, please set this up in the more long-term projects page for this repo.

Thank you and good luck ๐Ÿ˜„

[User page] Issues

  • Remove link to google when clicking on count of items for sale
  • Number of stars should be 5

Duplicate flagged entries

Create a separate branch and work on this "Improve-flagged"
Restructure flagged models to enforce the constraints below (Currently broken):

  • One user can flag a unique product at most once.
  • No way to extract a unique product (Suggest creating product id)

Overall styling

Decide font style and size for overall consistency on the website.

Landing page issues

Try to make page responsive. [Pictures tend to repeat on wider screens]

Enhance theme to fit the website better.

Improve the writeups

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.