preserve comments about smop HOT 5 CLOSED

2041f71 introduces conversion of single-line MATLAB comments to their python counterparts, by replacing % by #. Conversion of multi-line comments remains.

from smop.

Additional features to be implemented:

• multi-line comments
• function help text translation to docstring

from smop.

I think I integrated your code, thanks.

Please run the new code on fastsolver.m and fix the regressions.

python fastsolver.m
python a.py

*** error messages here ***

On Mon, Nov 25, 2013 at 12:18 PM, Ioannis Filippidis <
[email protected]> wrote:

Additional features to be implemented:

• multi-line comments
• function help text translation to docstring

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-29190204
.

Calligraphy of geese / Against the sky / The moon seals it /
(Buson/Hass)

from smop.

Yes, the changes have been integrated, thank you.

The problem was with the commented line

if curscore2<curscore
    moves=moves22;
else
    %   [moves1,yess]=dealWall1(A,B,w0,moves);
end;

in fastsolver.m. The result after translation with comments enabled was:

else:
    #   [moves1,yess]=dealWall1(A,B,w0,moves);
#etc

This caused an indentation error, because it requires that either a pass statement be inserted, or the comment deleted.
Enabling comments intends to keep all comments, so deleting the comment is not the behavior expected by the user.
So the preferred solution appears to be to detect this specific case and insert a pass statement.
1bc6c3a implements this.

Note that in general the same issue can occur also with while and for statements. These cases remain open. If the patch is agreed to be the appropriate fix, then I can extend it to cover these cases as well.

from smop.

@victorlei
Above some changes to support comments are linked. They are surprisingly not in the current master branch. Is this intended or by mistake?

from smop.