round and filter get converted to round_ and filter_ about smop HOT 7 CLOSED

Ok, I tracked it down to node.ident._backend which appends a _ to an identifier if it is in the reserved set. Of course, Matlab's filter and python's filter are completely different, but the round behaves essentially the same. Behaviour to be changed?

from smop.

Yep, this is a bug. Many of the common Matlab functions have mappings already, but these don't yet. To fix them, a function must be added to backend.py that implements the transformation.

from smop.

The scipy lfilter needs to be imported from the scipy.signal module. What is the best way to do this? Put it in the _backend for node.filter?

from smop.

Eventually, we'll want a system for tracking which imports are used, and then generate only those. For now, it's fine to drop the import statement in the _backend code. Maybe I'll look into an import-cleanup PR...

from smop.

Well, I tried putting it in the _backend code, it led to weird consequences like:

a = from scipy.signal import lfilter
lfilter(b,c,d)

I've finally just caved in and put the line import scipy.signal in main.py

I think an import tracking system will be a great thing.

from smop.

Ok, I've got a few functions implemented at seden@2486a1d

I'm working off @victorlei's 0.25 branch. I'll create a pull request if @victorlei okays it.
I'm new to github, never done a merge or pull request before so let me know if I'm doing something wrong.

from smop.

Just go ahead and create the PR now. That makes it much easier to see and comment on your changes. Also, thanks!

from smop.