Giter VIP home page Giter VIP logo

Comments (2)

crobinso avatar crobinso commented on September 28, 2024

Thanks for the report. @ladipro is that correct? If so I think all we need is this diff, but please confirm before I push

diff --git a/util/filemap.py b/util/filemap.py
index 376f5da..73a2e7f 100644
--- a/util/filemap.py
+++ b/util/filemap.py
@@ -118,6 +118,8 @@ FILELISTS['vioinput:w7'] = _vioinputfiles + ['WdfCoInstaller01009.dll']
 FILELISTS['vioinput:2k8R2'] = FILELISTS["vioinput:w7"]
 FILELISTS['vioinput:w8'] = _vioinputfiles + ['WdfCoInstaller01011.dll']
 FILELISTS['vioinput:w8.1'] = FILELISTS["vioinput:w8"]
+FILELISTS['vioinput:2k12'] = FILELISTS["vioinput:w8"]
+FILELISTS['vioinput:2k12R2'] = FILELISTS["vioinput:w8"]
 # win10+ doesn't need .dll
 FILELISTS['vioinput'] = _vioinputfiles

from virtio-win-pkg-scripts.

ladipro avatar ladipro commented on September 28, 2024

Nice catch! Yes, WdfCoInstaller01011.dll is missing.

All other drivers use the fallback to FILELIST['name'] for Windows 8, 8.1, 2k12, 2k12R2. Maybe it would be more consistent to do the same for vioinput but either would work. Thanks!

diff --git a/util/filemap.py b/util/filemap.py
index 8f99b62..ecea5c0 100644
--- a/util/filemap.py
+++ b/util/filemap.py
@@ -112,12 +112,12 @@ _vioinputfiles = [
     'vioinput.pdb',
     'vioinput.sys',
 ]
+FILELISTS['vioinput'] = _vioinputfiles + ['WdfCoInstaller01011.dll']
 FILELISTS['vioinput:w7'] = _vioinputfiles + ['WdfCoInstaller01009.dll']
 FILELISTS['vioinput:2k8R2'] = FILELISTS["vioinput:w7"]
-FILELISTS['vioinput:w8'] = _vioinputfiles + ['WdfCoInstaller01011.dll']
-FILELISTS['vioinput:w8.1'] = FILELISTS["vioinput:w8"]
 # win10+ doesn't need .dll
-FILELISTS['vioinput'] = _vioinputfiles
+FILELISTS['vioinput:w10'] = _vioinputfiles
+FILELISTS['vioinput:2k16'] = FILELISTS['vioinput:w10']

from virtio-win-pkg-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.