Imported dependency file executed twice about vitest HOT 3 CLOSED

I've seen a similar issue recently and your case is somewhat similar where wagmi is somehow inlined (i.e. processed vite/vitest transform).

I thought there might be some packaging issue of wagmi, but they are all green on publint, so there might be a problem with Vitest's externalization heuristics.

• https://publint.dev/[email protected]
• https://publint.dev/@rainbow-me/[email protected]

For the time being, I think it should be safe to explicitly set server.deps.external, so that wagmi always ends up with import("wagmi"), meaning there is only a single copy managed by NodeJs.

import { defineConfig } from "vitest/config";

export default defineConfig({
  test: {
    environment: "jsdom",
    server: {
      deps: {
        external: ["wagmi"]
      }
    }
  },
});

I'll need to look into further to see where the issue lies.

from vitest.

Thank you for help, I can confirm that this workaround/fix works!

from vitest.

Vitest's externalization heuristic is based on isValidNodeImport and this might be the one having an issue.

• #4368

As mentioned in the comment, isValidNodeImport seems to be copied from mlly, but the original one actually has a flipped condition where it checks pkg.type === "module" before .../esm/...js:

https://github.com/unjs/mlly/blob/c5bcca0cda175921344fd6de1bc0c499e73e5dac/src/syntax.ts#L82-L90

  const package_ = await readPackageJSON(resolvedPath).catch(() => {});
  // @ts-ignore
  if (package_?.type === "module") {
    return true;
  }

  if (/\.(\w+-)?esm?(-\w+)?\.js$|\/(esm?)\//.test(resolvedPath)) {
    return false;
  }

wagmi is resolved to ./dist/esm/exports/index.js, so the regex check hits first and isValidNodeImport is returning false on Vitest.

I wonder if Vitest introduced this flipped version on purpose or it may be a simple oversight. The PR #4368 is quite big, so I haven't gone through all the context.

from vitest.