Giter VIP home page Giter VIP logo

gouv-api-library's People

Contributors

webeweb avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

Forkers

odolbeau

gouv-api-library's Issues

Incoherent return type

Hello,

Thank you for this bundle ! I was wondering, in class ApiProvider, method search, the return type is FeatureCollection :

public function search(SearchRequest $request): FeatureCollection {

    $queryData = RequestSerializer::serializeSearchRequest($request);

    $rawResponse = $this->callApi($request, $queryData);

    return ResponseDeserializer::deserializeSearchResponse($rawResponse);
}

But the method deserializeSearchResponse can return null (?FeatureCollection) :

public static function deserializeSearchResponse(string $rawResponse): ?FeatureCollection {

    $response = json_decode($rawResponse, true);
    if (null === $response) {
        return null;
    }

    return JsonDeserializer::deserializeFeatureCollection($response);
}

Best regards

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.