Giter VIP home page Giter VIP logo

Comments (4)

Mesoptier avatar Mesoptier commented on September 27, 2024

Oops, I made a mistake! I thought my config applied style-loader for my build script, but of course it's only being applied in the devserver script. Since it works just fine in the DevServer script, I'll close this issue now :)

from style-loader.

alexander-akait avatar alexander-akait commented on September 27, 2024

anyway we have small bug here, we should add path to file in build dependencies, will be fixed today

from style-loader.

Mesoptier avatar Mesoptier commented on September 27, 2024

Isn't the path automatically added as a dependency by webpack, since you're transpiling to require/import here?

style-loader/src/utils.js

Lines 132 to 138 in 6e70da0

if (insertType === "module-path") {
const modulePath = stringifyRequest(loaderContext, `${options.insert}`);
return esModule
? `import insertFn from ${modulePath};`
: `var insertFn = require(${modulePath});`;
}

from style-loader.

alexander-akait avatar alexander-akait commented on September 27, 2024

yes as dependency, but not as build dependency, this is close and will work, but if other plugin will want to get all build dependencies it can be problem, so make sense to mark this as dependency (require/import) and as build dependency (this.addBuildDependency), also webpack faster will be invalid cache

from style-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.