Side effects of styles defined for DateTimePicker and DatePicker about orc.controls HOT 8 CLOSED

@ceo1647, please look into this issue

from orc.controls.

but if this is urgent for you, @jdehaan , then you can try to fix it by yourself and make pull request

from orc.controls.

It's not so urgent we stick to the old version at the moment. Unfortunately I am not an expert for styling issues. I struggle and fight all the time and just stick to defaults. I enjoy WPF for MVVM more than for the ability to theme and style (in the end to me ability to style is of no importance) But here the is a functional impact of styles. I am not sure how to fix it.

I had however a look in the code (Orc.Controls/src/Orc.Controls/Orc.Controls.Shared/Controls/DatePicker/Themes/DatePickerControl.generic.xaml) and I suspect the culprit is the removal of the lines

<Style TargetType="{x:Type local:DatePickerControl}"> <Style.Resources>

This "scoped" nicely everything. Due to the change for 1.3.0 and the scope removal IMHO the styles coming below apply globally. The ControlTemplate has a key but many styles below do not and thus AFAIK apply directly always to the TargetType.

But unfortunately I cannot judge what would be a clean fix for this issue...

from orc.controls.

We should never set default styles without an explicit key. We probably added a default margin to the types, not with the actual key so need to look into this.

from orc.controls.

Yes. Some default styles are applied globaly now. This is not good, thanks @jdehaan for indicating a bug. Will fix it soon

from orc.controls.

@jdehaan, we have released Orc.Controls v1.3.5-beta12
it is working good for us. Could you please check if we have fixed the issue?

from orc.controls.

Good job! I could not observe the negative effects anymore after updating to the mentioned version.

from orc.controls.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from orc.controls.