Comments (5)
kislyuk
commented on September 1, 2024
Thanks Vic, this sounds reasonable, although I haven't looked thoroughly into how this modifies the current behavior yet.
To start, could you please open a pull request with this change? You can simply navigate to https://github.com/kislyuk/signxml/blob/master/signxml/__init__.py, click the edit button on the top right, paste your changes, and open the PR from there.
from signxml.
viclevy
commented on September 1, 2024
Done.
Thanks,
Vic.
from signxml.
kislyuk
commented on September 1, 2024
It appears that you never actually opened the pull request.
from signxml.
kislyuk
commented on September 1, 2024
I think you meant to click the green button here: https://github.com/kislyuk/signxml/compare/master...viclevy:patch-1?expand=1
from signxml.
viclevy
commented on September 1, 2024
Future release will include a fix for this - closing this issue.
Thank you,
Vic.
from signxml.
Related Issues (20)
- PKCS#11 support HOT 15
- Failed to sign in the desired format HOT 2
- Allow pretty-printing
- Problem with the strip_pem_header function HOT 4
- Sign xml with thumbprint HOT 3
- _check_key_value_matches_cert_public_key overwrites public_key variable for ECDSA HOT 1
- XAdESSigner creates certificate digests that fail to verify HOT 7
- XADES sign has always_add_key_value: bool = True
- Support for multiple signatures HOT 6
- <ds:KeyValue> is not enough for XMLVerifier to verify signature HOT 5
- Validate x.509 cert value is a valid certificate before inlining contents into signature HOT 3
- How to sign xml using SHA1 HOT 2
- RSA signature did not verify HOT 2
- Bad Signature - unsure of how to debug further HOT 1
- Can not run the synopsis example: Missing child element(s). HOT 3
- DeprecationWarning: verify() from OpenSSL.crypto is deprecated HOT 5
- Return type incorrect for `XMLVerifier.verify` when `expect_references=1` HOT 3
- xml sample from samltool.io does not verify HOT 1
- OpenSSL Verify is deprecated HOT 2
- Kantara interop profile requirements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from signxml.