Comments (7)
fbernier
commented on September 27, 2024
So I've done this thing and specs are still passing but I am not very experienced with this stuff and it might be wrong and I guess this breaks backward compatibility.
If you think it looks good I can patch it for backward compatibility and make a PR.
from zookeeper.
slyphon
commented on September 27, 2024
Hey, sorry for the delay in getting back to you. It looks like the eventmachine patch was related to two different calls though? I guess most importantly, does it work after doing this? :)
If you can patch it for backwards compatibility, it looks good to me.
from zookeeper.
fbernier
commented on September 27, 2024
It looks like rb_thread_fd_select is ruby1.9.2+. Does this library still want to support 1.8?
from zookeeper.
eric
commented on September 27, 2024
Yes, I still want to support ruby 1.8.
from zookeeper.
korczis
commented on September 27, 2024
@eric Really willing to support 7 years old ruby version? Why? Just asking.
from zookeeper.
eric
commented on September 27, 2024
Because I am still using it in places and I haven't seen the pain of continuing to supporting it to be very large.
from zookeeper.
slyphon
commented on September 27, 2024
@korczis rumor has it a certain popular social network still uses 1.8.7 in production #JustSayin
from zookeeper.
Related Issues (20)
- Zookeeper fails to compile on Alpine >= 3.13 HOT 1
- Failure to build zookeeper gem's native extension on linux-aarch64 HOT 3
- Zookeeper Driver Update HOT 3
- Zookeeper installation failing since the latest update HOT 3
- Gem install fails for Ruby 3.2 in MacOS 12.6 HOT 4
- JRuby: LoadError: no such file to load -- log4j HOT 1
- Failure to install on OS X 10.10 Yosemite HOT 5
- Issue installing 1.4.6 on OS X 10.10 & ruby 2.1.2p95 HOT 2
- ArgumentError - too large fdsets: HOT 2
- install fails on 64-bit Linux HOT 4
- Is the log4j gem a hard requirement or does log4j just need to be on the classpath HOT 1
- Can't install with ruby 1.9.3 HOT 1
- Publish java version to rubygems HOT 2
- Failure to build on powerpc64le HOT 1
- Does we have a solution to build zookeeper on os x yosemite 10.10.5 HOT 5
- Compilation Error with GCC 8 HOT 14
- zookeeper zk doesn't support ttl container nodes
- Expose reconfig calls from the API
- New gem release? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zookeeper.