Giter VIP home page Giter VIP logo

Comments (2)

05nelsonm avatar 05nelsonm commented on June 24, 2024

This is related to kmp-tor, yah?

I really do not want to break the current API and hope there is a solution via a deprecation cycle.

If I were to:

  • copy/paste the current builder classes/functions to a new package (e.g., ...encoding.base16.Builders.kt)
  • deprecate classes/functions in encoding.builders package
    • Want to leave them there to not break consumers' APIs
  • Release version 1.2.3
  • Update kmp-tor to use the new Builders.kt package path

Would you be able to update your module config in Sparrow Wallet to no longer export the ...builders path, and only export the ...builders.base* packages?

from encoding.

05nelsonm avatar 05nelsonm commented on June 24, 2024

Deprecation cycle did not work. JPMS is still throwing exception even when no references are had to the .builders package. Will need to remove the .builders packages from base16, base32, and base64 modules.

POA:

  • Release 1.2.3 with deprecation notices and a way for library consumers to gracefully update to new builder functions package locations.
  • Release 2.0.0 with API breaking changes (...encoding.builders package removed).
  • Add migration notes to the CHANGELOG and release notes.

from encoding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.