Improve the chaining by returning current object. about vexflow HOT 1 CLOSED

Agreed. This exists in some places, but not all. It would be useful to have
this everywhere (within reason).

Thanks,
Mohit.

On Tue, Sep 20, 2011 at 10:25 AM, f0t0n <
[email protected]>wrote:

I want to suggest to review the code and find the points where is possible
to return current object for chaining.

I've found one such point here:

https://github.com/0xfe/vexflow/blob/master/src/stavenote.js

line 269:

// Pre-render formatting
Vex.Flow.StaveNote.prototype.preFormat = function() {
 if (this.preFormatted) return;
 if (this.modifierContext) this.modifierContext.preFormat();

 this.setWidth(this.glyph.head_width + this.extraLeftPx +
this.extraRightPx);

 this.setPreFormatted(true);
}

It's obviously, that it is possible to write it like next one:

// Pre-render formatting
Vex.Flow.StaveNote.prototype.preFormat = function() {
 if (this.preFormatted) return this; // return this for chaining
 if (this.modifierContext) this.modifierContext.preFormat();

 this.setWidth(this.glyph.head_width + this.extraLeftPx +
this.extraRightPx);

 this.setPreFormatted(true);
 return this; // return this for chaining
}

Reply to this email directly or view it on GitHub:
#25

Mohit Muthanna [mohit (at) muthanna (uhuh) com]

from vexflow.