Comments (1)
Agreed. This exists in some places, but not all. It would be useful to have
this everywhere (within reason).
Thanks,
Mohit.
On Tue, Sep 20, 2011 at 10:25 AM, f0t0n <
[email protected]>wrote:
I want to suggest to review the code and find the points where is possible
to return current object for chaining.I've found one such point here:
https://github.com/0xfe/vexflow/blob/master/src/stavenote.js
line 269:
// Pre-render formatting Vex.Flow.StaveNote.prototype.preFormat = function() { if (this.preFormatted) return; if (this.modifierContext) this.modifierContext.preFormat(); this.setWidth(this.glyph.head_width + this.extraLeftPx + this.extraRightPx); this.setPreFormatted(true); }It's obviously, that it is possible to write it like next one:
// Pre-render formatting Vex.Flow.StaveNote.prototype.preFormat = function() { if (this.preFormatted) return this; // return this for chaining if (this.modifierContext) this.modifierContext.preFormat(); this.setWidth(this.glyph.head_width + this.extraLeftPx + this.extraRightPx); this.setPreFormatted(true); return this; // return this for chaining }Reply to this email directly or view it on GitHub:
#25
Mohit Muthanna [mohit (at) muthanna (uhuh) com]
from vexflow.
Related Issues (20)
- Dot distance from eighth note is miscalculated? HOT 25
- issue with generateBeams and mixed subdivisions HOT 12
- Could you release the latest changes or add me (acelerationa) to the collaborator of the npm project? HOT 3
- Is it possible to draw tuplet number closer to group beamings? HOT 7
- Flow.keyProperties hangs in certain contexts HOT 2
- Presentation of StaveNote keys in chords HOT 5
- When adding stave notes to a voice, and rendering the accidental doesn't show. HOT 1
- Bends with different lengths HOT 3
- Gradient Note Head HOT 1
- stave.addKeySignature for bass clef without visible bass symbol HOT 6
- Other time signatures than 4/4 HOT 2
- Improve Curve API HOT 3
- Angled and square fermatas HOT 1
- Modifiers are misplaced when justifying staves with different startX (e.g. different keys) HOT 3
- Make PedalMarking boundaries configurable
- Best way to create a custom key signature? HOT 2
- Coloring note heads in chords HOT 1
- Is there a way to extract the SVG of a component from this library? HOT 4
- Allow measure rests to be used within odd time signatures HOT 1
- Support prebends
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vexflow.