Giter VIP home page Giter VIP logo

Comments (2)

bobbinth avatar bobbinth commented on August 30, 2024

One option which could minimize the amount of changes needed is to use something like maybe-async proc macro. A slightly modified version of the macro will soon be merged into Winterfell (see facebook/winterfell#276). Once this is done, we could:

  • Add async feature to the miden-tx crate (turned off by default).

  • Change DataStore trait to look something like:

    #[maybe_async]
    pub trait DataStore {
        async fn get_transaction_inputs(
            &self,
            account_id: AccountId,
            block_ref: u32,
            notes: &[NoteId],
        ) -> Result<TransactionInputs, DataStoreError>;
    
        async fn get_account_code(&self, account_id: AccountId) -> Result<ModuleAst, DataStoreError>;
    }

Then, when the crate is used with async feature enabled, we'd get the async versions of the trait, and we'd get the default version otherwise.

from miden-base.

phklive avatar phklive commented on August 30, 2024

Closed by #725

from miden-base.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.