Comments (2)
One option which could minimize the amount of changes needed is to use something like maybe-async proc macro. A slightly modified version of the macro will soon be merged into Winterfell (see facebook/winterfell#276). Once this is done, we could:
-
Add
async
feature to themiden-tx
crate (turned off by default). -
Change
DataStore
trait to look something like:#[maybe_async] pub trait DataStore { async fn get_transaction_inputs( &self, account_id: AccountId, block_ref: u32, notes: &[NoteId], ) -> Result<TransactionInputs, DataStoreError>; async fn get_account_code(&self, account_id: AccountId) -> Result<ModuleAst, DataStoreError>; }
Then, when the crate is used with async
feature enabled, we'd get the async versions of the trait, and we'd get the default version otherwise.
from miden-base.
Closed by #725
from miden-base.
Related Issues (20)
- Challenges surrounding sub-second order-book performance on Miden
- Miden Assembly Linter? HOT 3
- Allow user to set the aux field when creating a note HOT 1
- Using hmerge to hash 9 or more stack elements HOT 16
- Add CI job for `doc` + make sure that Miden base passes `make doc` HOT 1
- winter_rand_utils Compiled Under Testing Feature Breaks for WASM Builds HOT 1
- Refactor `apply_delta` for Storage Maps HOT 3
- Allow increasing an account's nonce without changing its state HOT 1
- Add `create_wallet_with_custom_code` wallet helper function in miden-lib HOT 5
- Refactor transaction kernel events and errors HOT 1
- Make memory setters consistent HOT 1
- Checking that a transaction does not consume two identical notes
- Update names used for input/output notes HOT 4
- Refactor batch/block note tree structure
- Refactor `NoteOrigin` / `NoteInclusionProof` structs HOT 3
- Fix the stack management for account procedures HOT 7
- Allow setting block timestamp and block number when using TransactionContextBuilder HOT 3
- Refactor delta's vault and storage to use maps HOT 2
- feat: add a procedure for basic wallets that creates notes with 0 or more assets HOT 1
- Refactor account storage to use sequential hash rather than a Merkle tree
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miden-base.