Giter VIP home page Giter VIP logo

Comments (6)

iamhssingh avatar iamhssingh commented on August 16, 2024 1

@sumit4613 We will have to fix this piece of code. Looks like instamojo library has been updated or either this was not ever run. You are point-blank on the RCA. Can you raise a PR for this fix?

Also, let's start building test cases on this.

from drf-instamojo.

sumit4613 avatar sumit4613 commented on August 16, 2024

@Nirpesh87 According to the traceback here, the reason you're getting TypeError is because payment_request_imojo.get('modified_at') here returns str and not datetime.datetime. And you can't compare different types. Also, I'm not sure why it returns str, if you can show me your code which is causing this maybe I can help in this issue.

Please let us know the steps to reproduce this. I'll try to reproduce it myself.

Thanks.

from drf-instamojo.

Nirpesh87 avatar Nirpesh87 commented on August 16, 2024

@Nirpesh87 According to the traceback here, the reason you're getting TypeError is because payment_request_imojo.get('modified_at') here returns str and not datetime.datetime. And you can't compare different types. Also, I'm not sure why it returns str, if you can show me your code which is causing this maybe I can help in this issue.

Please let us know the steps to reproduce this. I'll try to reproduce it myself.

Thanks.

@sumit4613 , should i create a different view for PaymentSerializer to save payment record?

from drf-instamojo.

sumit4613 avatar sumit4613 commented on August 16, 2024

@Nirpesh87 According to the traceback that was shared by you. The problem isn't in View or Serializer. There's some issue in signal which was called when saving Payment object. I'll have to look why payment_request_imojo.get('modified_at') is returning str rather than datetime.datetime. As @iamhssingh suggested maybe instamojo have updated their library or there's some issue in this code. I'll have to debug this and will raise a PR for this issue.

If you can fix this issue, please let us know or raise a PR with your changes.

Thanks!

from drf-instamojo.

Nirpesh87 avatar Nirpesh87 commented on August 16, 2024

Waiting for this bug to be fixed :(

from drf-instamojo.

sumit4613 avatar sumit4613 commented on August 16, 2024

@Nirpesh87 We're working on the issue, we'll create a new release in a day or two. So please be patient.

from drf-instamojo.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.