Comments (8)
Same issue here.
from action-wordpress-plugin-deploy.
@dinhtungdu @iamdharmesh its worth chatting about the separate approaches for this in #30 and #56, to see which approach might be most optimal (or if a third option might be better).
from action-wordpress-plugin-deploy.
@jeffpaul between #30 and #56, I'm leaning towards the latter one. But I have an issue with both PRs: if the plugin files are built into a custom folder, then we don't need the ignore files because all files in that custom folder are meant to be deployed.
IMO, we should treat the custom build folder as a separate scenario instead of the way those two PRs are doing. Because of that, I'm not really convinced by any of those PRs. I'll work on a PR this week to demonstrate my idea.
from action-wordpress-plugin-deploy.
I'm sure it's possible but I don't know yet if this is a direction I'd like this action to take. The docs you linked are describing directly running a command in a directory and does not impact this actual action, which does some directory changes anyway.
Can you describe what you're doing that the build is located in a subdirectory like that?
from action-wordpress-plugin-deploy.
@helen I have a similar question. I have a Github repository and the plugin's code is in the subdirectory of this repository. And I would like to keep it this way because there is some supportive code I see no reason to push to WordPress servers.
It would be awesome if I could set a new env variable with the directory of the plugin. Maybe, it is possible?
from action-wordpress-plugin-deploy.
@helen if I understand the code correctly, it could be done something like this:
`
if [[ -z "$PLUGIN_DIR" ]]; then
PLUGIN_DIR=""
fi
....
rsync -rc "$TMP_DIR/$PLUGIN_DIR/" trunk/ --delete
`
from action-wordpress-plugin-deploy.
@helen It's just how my workflow is laid out. I usually keep the build directory separate from working directory. And this is something I do quite often.
It'd be grreat if @sery0ga's suggestion could make it in.
from action-wordpress-plugin-deploy.
@helen I know this is an old issue but wanted to chime in with another scenario to consider.
I am looking at using PHP-Scoper so I can include third party packages without having to worry about conflicts.
As far as I can tell there doesn't seem to be much consensus on the best way to use PHP-Scoper in a WordPress plugin - I have seen wildly different approaches in plugins like wordpress-seo and google-site-kit.
But by default (the way I have set it up so far) it creates a "build" subdirectory which contains a complete scoped version of the plugin that is ready to deploy.
I don't know yet if this is a direction I'd like this action to take.
Have you had any new thoughts on whether this is something you would like to support going forward?
from action-wordpress-plugin-deploy.
Related Issues (20)
- Option for a trunk-only deployment HOT 2
- questions regarding the build process
- README Example should indicate actions/checkout@master is required HOT 1
- Changing file X is forbidden by the server HOT 1
- [Feature Request] Update readme.txt while deploying HOT 3
- fatal: detected dubious ownership in repository at '/github/workspace' HOT 10
- Sync from GIT to SVN fails for tags HOT 7
- set-output command deprecated in last release HOT 4
- Support a "DRY RUN" mode that can be used while testing HOT 3
- Fix deploy script to not attempt re-publishing the same version of a plugin
- Action workflow examples
- Dry run is on by default HOT 2
- Unable to deploy to WP (for two releases) despite workflow marked as succeeded HOT 1
- svn: E155007: '/somedir/somefile' is not a working copy HOT 3
- If the version already exists in SVN and generate-zip is configured, it should also generate the ZIP HOT 1
- After first action I'm getting "trunk is not a working copy" error HOT 1
- Action fails when the .distignore file is not present.
- WP CLI `.distignore` syntax is changing HOT 2
- Use SVN copy from trunk to new tag folder to improve deploy times HOT 3
- What wrong with my action script? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-wordpress-plugin-deploy.