Giter VIP home page Giter VIP logo

Comments (5)

AlecRust avatar AlecRust commented on May 20, 2024 1

In order to comply with the changelog recommendations I'm restricting my changelog to only include the range between the two most recent major versions.

I suppose since this action performs the interaction with the SVN repository I was thinking it could have a keep-last-releases option where you specified the number of tags to keep in the SVN repository

Or, a keep-tags-since option where you specified a tag name and tags before that version were deleted from the SVN repository.

from action-wordpress-plugin-deploy.

helen avatar helen commented on May 20, 2024 1

Hello! I'd like to keep this action tightly focused on deployment; what you're describing is something I would frame as more of a clean up or maintenance type of task. Whether doing this is necessary or not, I'll refrain from opining, but IMO best practice as far as CI goes would be to run that as a separate step in your workflow so it is separated from the deployment (e.g. if deployment otherwise succeeds you don't want it to show a failure of deployment). I see two potential paths forward if you're hoping for a workflow to manage this for you:

  • Add a step that directly runs the deletion commands for you (SVN is available on their Ubuntu runners)
  • Create an Action that does the deletion, likely based on passed args, and then reference that in a new step in your workflow file

from action-wordpress-plugin-deploy.

jeffpaul avatar jeffpaul commented on May 20, 2024

@AlecRust the Plugin Handbook does not seem to make that a recommendation so much as point out its an option that does not have any listed positive effect:

Since SVN is a release repository, many developers chose to remove older (non-supported) versions of their plugins. As of 2019, this no longer speeds up releases, as the build process only addresses tags with changed files.

The easiest path to handling this, if its desired, is probably directly in SVN itself. For example: https://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-rename.html.

from action-wordpress-plugin-deploy.

AlecRust avatar AlecRust commented on May 20, 2024

This is probably a better reference:

How many old releases should I keep in SVN?

As few as possible. Very rarely does anyone need your old code in the release repository. Remember, SVN is not meant for your code versioning. You can use Github for stuff like that. SVN should have your current release versions, but you don’t need all the minor releases to all the previous versions. Just the last one or two for them is good.

WordPress also recommends only including the most recent couple major versions in your readme.txt changelog:

How many versions should I keep in my changelog?

Always keep the current major release in your change log. For example, if your current version is 3.9.1, you’ll want that and 3.9 in the change log. Older versions should be removed and migrated to a changelog.txt file. That will allow them to be accessible to users, while keeping your readme shorter and more pertinent. At most, keep the most recent version of your plugin and one major version back in your readme’s changelog.

So it seems logical to keep the same tags in SVN that you also have listed in the changelog. No doubt I can do this manually, but I'm looking to automate it.

from action-wordpress-plugin-deploy.

jeffpaul avatar jeffpaul commented on May 20, 2024

@AlecRust I'm not immediately sure how this action would handle this. What would be your expected workflow?

from action-wordpress-plugin-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.