Confusion in the links on the Contributing Guidelines about engineering-best-practices HOT 2 OPEN

@glebkema thanks for the feedback, what you're seeing is definitely odd and something that should get cleaned up.

The links on the Issues page are utilizing the 10up default Contributing Guidelines markdown file, so that'll likely be resolved by creating a replica of https://github.com/10up/.github/blob/master/CONTRIBUTING.md and customizing it as necessary for the Engineering Best Practices.

The Contribute page, honestly, was not a page I was aware of and looks to be a hidden page in the GitHub UI. Resolving for the Issues page above will likely (hopefully?) resolve this dead link.

The PR template is also using the 10up default PR template file, so that'll likely be resolved by creating a replica of https://github.com/10up/.github/blob/master/.github/PULL_REQUEST_TEMPLATE.md and customizing it as necessary for the Engineering Best Practices. I'll make a note that removing the link in the .github repo version of this file is likely warranted to avoid this same scenario for other repos inheriting this file.

Finally, we may want to link to the newly created CONTRIBUTING.md file from the https://10up.github.io/Engineering-Best-Practices/#contributing section to provide more details than what's currently stated.

@timwright12 if you're 👍 on these changes, then I'll work on a PR for you to review.

from engineering-best-practices.

Those changes sound good to me @jeffpaul

from engineering-best-practices.