Comments (3)
I started working on this over the weekend and ran into a bit of a blocker. BrainMonkey requires PHP 5.4 or higher. WP_Mock currently requires 5.3 or higher. I'm hesitant to bump the version requirement of WP_Mock since 5.3 still accounts for a very large number of WordPress installations (including a large number of sites on WP Engine).
At this point, as I see it, we're left with 3 options:
- Bump our own required PHP version
- Close this issue as
wontfix
- Try to get BrainMonkey to refactor with 5.3 support
I'm really leaning towards 2. 3 sounds both unreasonable and unlikely. Thoughts?
from wp_mock.
This change is even harder to justify when one considers that individual projects can still use BrainMonkey together with WP Mock and opt to use BrainMonkey's (IMO) superior DSL for setting expectations on code. Since both libraries use Mockery, the validation, etc. should be the same.
from wp_mock.
Was an interesting idea at the time. Closing for now.
from wp_mock.
Related Issues (20)
- README.md sample test case is incompatible with mock class HOT 1
- Cannot install WP_Mock HOT 2
- Reply to filter 'with' anything HOT 1
- Add expectHookRemoved and expectHookNotRemoved support
- WP_Mock breaks with PhpUnit >= 9.5.0 HOT 6
- Extend TestCase from WP_UnitTestCase instead of \PHPUnit\Framework\TestCase HOT 2
- AnyInstance matcher for expectHookAdded
- _n() function mocker always returns first string (singular)
- Unable to mock function to return an empty array.
- WP_Mock tests should go in own namespace
- WP_Mock TestCase is referencing method removed from PhpUnit
- Move TestCase::mockStaticMethod into trait HOT 1
- WP_Mock should define its own exception objects
- Introduce a builder for WP functions and WP constants mocks
- Remove WP_Mock/Loader
- Change license from GPL 2.0 to BSD-3-Clause HOT 13
- Move documentation over GitBook
- PHP 8.2 Dynamic Property Deprecation HOT 1
- How to Mock wp_send_json_error() HOT 5
- Update GitHub workflow with the setup-php action to run tests in PHP 7.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp_mock.