Giter VIP home page Giter VIP logo

Comments (3)

johnpbloch avatar johnpbloch commented on May 20, 2024

I started working on this over the weekend and ran into a bit of a blocker. BrainMonkey requires PHP 5.4 or higher. WP_Mock currently requires 5.3 or higher. I'm hesitant to bump the version requirement of WP_Mock since 5.3 still accounts for a very large number of WordPress installations (including a large number of sites on WP Engine).

At this point, as I see it, we're left with 3 options:

  1. Bump our own required PHP version
  2. Close this issue as wontfix
  3. Try to get BrainMonkey to refactor with 5.3 support

I'm really leaning towards 2. 3 sounds both unreasonable and unlikely. Thoughts?

from wp_mock.

johnpbloch avatar johnpbloch commented on May 20, 2024

This change is even harder to justify when one considers that individual projects can still use BrainMonkey together with WP Mock and opt to use BrainMonkey's (IMO) superior DSL for setting expectations on code. Since both libraries use Mockery, the validation, etc. should be the same.

from wp_mock.

ericmann avatar ericmann commented on May 20, 2024

Was an interesting idea at the time. Closing for now.

from wp_mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.