Giter VIP home page Giter VIP logo

Comments (5)

danbrady avatar danbrady commented on August 22, 2024 1

I was able to squash this bug. Here's some screens from my local env:

Screen Shot of normal width

Screen Shot of narrow width now fixed

from 18f.gsa.gov.

MelissaBraxton avatar MelissaBraxton commented on August 22, 2024 1

Thanks so much, @danbrady!

from 18f.gsa.gov.

danbrady avatar danbrady commented on August 22, 2024

I'd like to help with this issue. Adding text to any header tags (including h2 and h3 within the content) to a narrow page on prod and watch the column grow like magic!

Animation of column resizing as text is added to the header.

I suspect it might be related to the flex grid layout. I'll keep looking into it.

(Unrelated but there is an errant quote in the post.html template as well. I removed it locally but it didn't have any effect on the rendering.)

Code snippet of extra quote

from 18f.gsa.gov.

geekygirlsarah avatar geekygirlsarah commented on August 22, 2024

Adding text to any header tags (including h2 and h3 within the content) to a narrow page on prod and watch the column grow like magic!

Interesting catch!

I suspect it might be related to the flex grid layout. I'll keep looking into it.

If you wanted to, that'd be nice. I'll probably also check it out soon too to see if I can find it.

(Unrelated but there is an errant quote in the post.html template as well. I removed it locally but it didn't have any effect on the rendering.)

Also good catch! You're welcome to PR it, or I can do it soon and I'll add you as a co-author.

from 18f.gsa.gov.

danbrady avatar danbrady commented on August 22, 2024

Thanks, @geekygirlsarah!

If you wanted to, that'd be nice. I'll probably also check it out soon too to see if I can find it.

FWIW: It appears that the measure utility / max-width set on the paragraphs might be related as well.

(Unrelated but there is an errant quote in the post.html template as well. I removed it locally but it didn't have any effect on the rendering.)

Also good catch! You're welcome to PR it, or I can do it soon and I'll add you as a co-author.

Submitted PR #3678 - It's nominated for PR of the year! 🤞

from 18f.gsa.gov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.