Accessibility contrast bug on "our work" page with Chrome about 18f.gsa.gov HOT 8 CLOSED

So, I thiiiink the source of the error is somewhere in ...assets/css/_components/button.scss; where there is a missing :visited state that needs to be copied and pasted down, but could use another set of eyes to verify that

from 18f.gsa.gov.

Seems to be an issue with the "followed link" color.

from 18f.gsa.gov.

I can certainly look, but offhand to we know if this is a Design System issue or local only to this page? And if so, should we prioritize a quick-local fix first?

from 18f.gsa.gov.

.usa-section--dark a:visited { color: #dfe1e2; }

Thinking aloud as I investigate. The link is classed like it's on a dark background (it doesn't seem to know it's on a light button); so that's a thing. I'll look into how widespread that is or if it just needs an additional class

from 18f.gsa.gov.

It also isn't a button at all, at least in code, and this seems like one of those semantic edge cases

from 18f.gsa.gov.

Scratch that, it is a usa-button but is still getting the visiting link style applied like I said two comments up. I also replicated this in Safari

from 18f.gsa.gov.

Same issue also happens on the homepage in the "What 18F can do" and "Recent blog posts" sections, so I suspect any buttons on dark backgrounds would see this effect

from 18f.gsa.gov.

So for this site, it seems we implemented an 18F specific button class, an18f-button--accent, that has slightly different rules from usa-button. an18f-button--accent seems to be used exclusively for these dark background sections and has the light blue background color. It seems, though, for both button styles, the intent is for it to not change color at all once visited. There seems to be a cascade error for the 18F one though and it's getting USWDS' style of any visited link on a dark background instead of the intended, unchanged, color.

from 18f.gsa.gov.