Comments (8)
So, I thiiiink the source of the error is somewhere in ...assets/css/_components/button.scss
; where there is a missing :visited
state that needs to be copied and pasted down, but could use another set of eyes to verify that
from 18f.gsa.gov.
Seems to be an issue with the "followed link" color.
from 18f.gsa.gov.
I can certainly look, but offhand to we know if this is a Design System issue or local only to this page? And if so, should we prioritize a quick-local fix first?
from 18f.gsa.gov.
.usa-section--dark a:visited { color: #dfe1e2; }
Thinking aloud as I investigate. The link is classed like it's on a dark background (it doesn't seem to know it's on a light button); so that's a thing. I'll look into how widespread that is or if it just needs an additional class
from 18f.gsa.gov.
It also isn't a button at all, at least in code, and this seems like one of those semantic edge cases
from 18f.gsa.gov.
Scratch that, it is a usa-button
but is still getting the visiting link style applied like I said two comments up. I also replicated this in Safari
from 18f.gsa.gov.
Same issue also happens on the homepage in the "What 18F can do" and "Recent blog posts" sections, so I suspect any buttons on dark backgrounds would see this effect
from 18f.gsa.gov.
So for this site, it seems we implemented an 18F specific button class, an18f-button--accent
, that has slightly different rules from usa-button
. an18f-button--accent
seems to be used exclusively for these dark background sections and has the light blue background color. It seems, though, for both button styles, the intent is for it to not change color at all once visited. There seems to be a cascade error for the 18F one though and it's getting USWDS' style of any visited link on a dark background instead of the intended, unchanged, color.
from 18f.gsa.gov.
Related Issues (20)
- Show banners on /blog
- Adjust positioning and aspect ratio of blog post banners
- replatform: missing section HOT 1
- replatform: missing id for headers (for anchors) HOT 6
- replatform: img alt has "undefined" (should be blank)
- replatform: title segments are swapped HOT 1
- replatform: missing aria-label HOT 3
- replatform: tag pages do not sort by last date
- replatform: redirect from team to author is not implemented HOT 5
- replatform: posts do not properly link to feed
- replatform: footnotes missing role attributes
- replatform: author page is missing tags HOT 1
- replatform: external links are not marked appropriately
- replatform: /contact is missing social media box HOT 1
- replatform: emails should not have external link? HOT 2
- https://18f.gsa.gov/our-work/federalist/ has the wrong template HOT 2
- BUG: Older blog post images sometimes have overlaid captions HOT 1
- BUG: Meta descriptions don't display on most pages HOT 1
- BUG: Related posts don't show up on new blog posts
- Remove CircleCI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 18f.gsa.gov.