Comments (11)
I bet we can probably get rid of it and use the official gem instead. @amoose do you recall what the aria-invalid branch was all about?
from identity-idp.
I replaced it with just:
gem 'simple_form'
and things basically worked fine.
from identity-idp.
😕 That is weird.
@monfresh Yes, it was 508-compliance. It adds aria-invalid attribute to fields with errors.
from identity-idp.
I just cloned my repo without issue ¯_(ツ)_/¯
We can switch to official simple_form gem for now, but I wanted to submit a 508-compliant or now a USDSWDS+508-compliant strategy for simple_form
from identity-idp.
what version of git are you running @greggersh?
from identity-idp.
It was 2.6.4/Apple Git, I just upgraded to 2.8.1 via homebrew, which did not fix it.
from identity-idp.
Greg, try running the laptop script.
from identity-idp.
@monfresh hmm, I'm probably not going to do that, and I don't think that should be a pre-req for getting an open source project running. I'm sure it's an awesome script, though. ;)
I've done some research and I think this is related to settings in my .gitconfig file related to vulnerability that came out earlier this year (January, I think?).
from identity-idp.
Yeah, that did it. I had to set the following in my ~/.gitconfig
file:
[transfer]
fsckobjects = false
[fetch]
fsckobjects = false
[receive]
fsckObjects = false
(they had previously been set to true
because of some vulnerability, which I can't find right now)
If I understand this correctly, the only solution I've found is to do a massive recopy of the repo, which will change all the git shas and basically destroy any connection between @amoose's fork and the base simple_form repo (so, not something to do willy-nilly).
from identity-idp.
Here's a related thread: ohmyzsh/ohmyzsh#4963
from identity-idp.
Thanks for that info, @greggersh. We will point to the latest gem and toss my fork. This feature is small and can be easily integrated in to the latest version. I will create an issue to update the gem. 😎
More information about fsckObjects:
from identity-idp.
Related Issues (20)
- Update dependencies in `@18f/identity-stylelint-config` to support stylelint v16 HOT 3
- c099c4b9756d116f5fb08bc588d49a43a6c6176c HOT 1
- Most users w/.gov email addresses can't have PIV cards and shouldn't be prompted to add one HOT 2
- Update stylelint config HOT 10
- FIDO/WebAuthn regression on Safari HOT 3
- API to be able to use it as a Login option for websites HOT 1
- Platofrm authenticators (TouchID/FaceID and Windows Hello) not suported HOT 2
- Deprecating `clipboard-polyfill` HOT 3
- OIDC tests use incorrect PKCE code_challenge computation
- Requesting query string for 'signup page' HOT 2
- By "same question", I meant whether we should be checking for SMS in this condition.
- Authentication Context Reference (ACR) implementation does not follow standard practices HOT 1
- Personal key sign-in message does not correctly substitute app name HOT 3
- Typo: Lettter
- FIDO2 enrollment fails in Firefox because AuthenticatorAttestationResponse.getTransports() is not supported HOT 3
- Missing option to add Face / Touch ID (WebAuthn passkey) logins HOT 3
- Incorrect CSP prevents redirect from OIDC logout confirmation page HOT 2
- For some apps, logout fails if user has logged in with another browser HOT 15
- Adding a passkey fails when using 1password's browser extension on Linux HOT 10
- Unable to log into my Trusted Traveler Program Account HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from identity-idp.