Comments (9)
Isn't the digitize
function supposed to take just one argument? I mean we can convert it to work with variadic arguments, but I am not sure this is necessary. Opinions?
from 30-seconds-of-code.
But what if user needs to input two digit numbers? Then it will not work as third snippet in issue is!
from 30-seconds-of-code.
The function signature indicates that only one argument should be passed. If we want to convert to a variadic function, we should do something like (off the top of my head, test this):
const digitize = (...args) => ['',...args].join('').split('').map(i => parseInt(i));
That one should work for variadic arguments.
from 30-seconds-of-code.
Then also whole two digit number is not going to be selected in array.
const digitize = (...args) => ['',...args].join('').split('').map(i => parseInt(i));
digitize(12,123,1234);
// (9) [1, 2, 1, 2, 3, 1, 2, 3, 4] , should be [12,123,1234]
from 30-seconds-of-code.
Not at all, the result is exactly as intended. It's suppose to split a number (or numbers) into an array of digits.
from 30-seconds-of-code.
I thought it should be like supporting two digit value also.
No problem if the main reason is to split out a single digit number.
from 30-seconds-of-code.
The original idea was to split one number into digits (which has valid use-cases as far as I can tell, had to do this in the past). I don't know if we have to make this variadic, as I can't remember the last time I had to digitize a bunch of numbers in the same array, plus you can digitize multiple values by sticking them in an Array and calling Array.map()
so I vote we keep as-is.
from 30-seconds-of-code.
Okay got it about the original idea !
sure you can now close this or maybe depend for more suitable outcome!
from 30-seconds-of-code.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.
from 30-seconds-of-code.
Related Issues (20)
- Merge two arrays and remove duplicate elements HOT 2
- CSVToArray will return an empty item for documents ending with \n HOT 2
- addDaysToDate fails with non-UTC timezone HOT 1
- A snippet folder dedicated to Angular
- Js
- Broken links HOT 4
- New snippet ideas HOT 1
- passive-scroll-listener-performance has obsolete/incorrect advice HOT 2
- Regarding the throttle function's question. HOT 7
- style: Centering the footer section ⏡ HOT 2
- Website Navigation Bar
- cookie parsing containing a `=` in value HOT 5
- [ BUG ] Missing space in footer section HOT 12
- Typo in the event-loop-explained.md snippet HOT 2
- fix: Unnecessary parameter in Queue class methods HOT 2
- Terminology issue in blog HOT 4
- :bug: Fix Footer settingsPath (GithHub,CC ,30-sec-of-code Link)
- Kindly add hacktoberfest label to your repo. HOT 1
- [Feature Request] : The border of search bar is not clearly visible .
- Typo on the website
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 30-seconds-of-code.