Garbage collection leak on Nuitrack.NET 0.30 about nuitrack-sdk HOT 4 CLOSED

Hi @vpenades,

Sorry for the issues you've encountered.

This problem will be fixed in the new release, which is planned next week.

from nuitrack-sdk.

@olga-komyakova Hi again, given that you're going to update the nuitrack.net.dll for the next version, I would like you to take these into consideration:

1. The Byte[] array that nuitrack.net.dll exposes is designed to make things easy for the end developer, in exchange for a performance loss. This is addressed by the fix I proposed a year ago. BUT, if the API exposes the internal pointer as an IntPtr, we can take advantage of that and avoid a memory block copy entirely, which would be a great performance improvement.

2. We're in the process of moving our projects to NetCore 3 , I am not sure which framework nuitrack.net.dll uses, but if it is one of the old NetFramework 3.5, or 4.5 etc, you should consider exploring how to make it work in NetCore..... most probably, you need to compile the wrapper targeting NetStandard2.0 or something like that. Right now there's probably a lot of clients still using NetFramework.... but everybody is moving towards NetStandard and NetCore.... so you should take that into account and update the framework accordingly.

3. Given that nuitrack.net.dll is just a wrapper and most probably it doesn't contain any "secret"... I would really consider publising it here at Github, as open source.

from nuitrack-sdk.

@vpenades We've released the new version, you can check it out.

from nuitrack-sdk.

Hi @olga-komyakova I've tested the latest version and I can see the IntPtr data is now exposed, which is much more convenient since it avoids doing a frame copy.

For those that still require a plain old c# array, it can be done in this way (requires c# unsafe mode):

var span = new Span<Byte>(frame.Data.ToPointer(), frame.DataSize);
var array = span.ToArray();

Thanks for fixing this issue!

from nuitrack-sdk.