Giter VIP home page Giter VIP logo

Comments (16)

wbsmolen avatar wbsmolen commented on July 17, 2024 1

@knkrth in server/modules/registration/signup.js, line 74. Change SignupSuccess to Signup and comment out the mailer.sendsignupconfirmation. Agnostic to UI, this will let you remove email verification from the sign up process

Withdrawals still require email verification and I'm working on a similar workaround

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

Is there is a way to disable E-Mail verification or can you implement SendGrid API (https://sendgrid.com/docs/Integrate/index.html?ls=Advertisement&cid=70180000000cl5Z&lsd=adwords&kw=Sendgrid%20com&mt=b&gaid=Integration_Sitelink&mc=Paid%20Search&mcd=AdWords&keyword=sendgrid%20com&network=g&matchtype=b&mobile=&content=&search=1&cvosrc=PPC.Google.sendgrid%20com&cvo_cid=Integration_Sitelink&gclid=EAIaIQobChMI1Kak2Yml2wIVCrDtCh1CpwNBEAAYASABEgLPyvD_BwE)

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

Or can you provide how to setup a E-Mail server on localhost & How to configure with the OpenTrade?

from opentrade.

wbsmolen avatar wbsmolen commented on July 17, 2024

+1. Azure blocks unauthenticated smtp requests. Need this functionality

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

@wbsmolen πŸ‘

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

I did changes as you suggested,

function SendConfirmEmail(req, res)
    {
        const strCheck = escape(utils.Hash(req.body['email']+Date.now()+Math.random()));
        emailChecker[strCheck] = {body: req.body, time: Date.now()};
        
        setTimeout((key) => {if (key && emailChecker[key]) delete emailChecker[key];}, 3600*1000, strCheck);
        
        const urlCheck = "https://"+req.headers.host+"/checkmail/"+strCheck;
        // mailer.SendSignupConfirmation
        (req.body['email'], "https://"+req.headers.host, urlCheck, ret => {
            if (ret.error)
            {
                SignupError(req, res, ret.message);
                return;
            }
            Signup(req, res, {});
        });
    }

Server starts without any error. When I click register the UI keeps loading & no Activity on the server log.

from opentrade.

wbsmolen avatar wbsmolen commented on July 17, 2024

@knkrth

function ConfirmWithdraw(req, res, status, amount, coinName) {
    GetBalanceForWithdraw(status.id, coinName, (err, balance) => {
        if (err.result == false)
            return utils.renderJSON(req, res, err);

        if (!utils.isNumeric(balance) || balance <= amount)
            return utils.renderJSON(req, res, { result: false, message: 'Insufficient funds' });

       // const strCheck = escape(utils.Hash(status.id + status.user + amount + req.body.address + Date.now() + Math.random()));
        const strCheck = "testconfirm"
        emailChecker[strCheck] = { userID: status.id, email: status.email, address: req.body.address, amount: amount, coinName: coinName, time: Date.now() };

        setTimeout((key) => { if (key && emailChecker[key]) delete emailChecker[key]; }, 3600 * 1000, strCheck);

        const urlCheck = "https://" + req.headers.host + "/confirmwithdraw/" + strCheck;
        //mailer.SendWithdrawConfirmation(status.email, status.user, "https://"+req.headers.host, urlCheck, ret => {
              //if (ret.error)
                //return utils.renderJSON(req, res, {result: false, message: ret.message});
         //});
        utils.renderJSON(req, res, {result: true, message: {}});
        
    });
};


Make your withdraw request and manually confirm by visiting https://host/confirmwithdraw/testconfirm

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

@wbsmolen I'm unable to login after Changing SignupSuccess to Signup and comment out the mailer.sendsignupconfirmation. On signup the UI keeps loading & Here is the log on server,

kartx@ubuntu:~/Download/opentrade/server$ sudo node main.js 
[sudo] password for kartx: 
SSL Proxy listening on port 40443
GetCoins Marycoin - Litecoin
SELECT ERROR: query=SELECT ROWID AS id, info FROM users WHERE id=undefined message=SQLITE_ERROR: no such column: undefined

How ever I did manage to setup a mail server on localhost. After the signup email conformation. Now I'm able to login.

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

@wbsmolen Did you find a way to disable email verification or change the API sendgrid for email verification?

from opentrade.

bihonglu avatar bihonglu commented on July 17, 2024

Not sure anyone want that. Security for an public exchange is must. The more the better

from opentrade.

Tr0j4n9 avatar Tr0j4n9 commented on July 17, 2024

Just giving this a little "bump"

from opentrade.

3s3s avatar 3s3s commented on July 17, 2024

Added this constant to disable email verivication https://github.com/3s3s/opentrade/blob/master/server/constants.js#L16
Please check it

from opentrade.

knkrth avatar knkrth commented on July 17, 2024

Ok

from opentrade.

 avatar commented on July 17, 2024

I would be interested in know what this error is, i see it on occasion.

SELECT ERROR: query=SELECT ROWID AS id, info FROM users WHERE id=undefined message=SQLITE_ERROR: no such column: undefined

from opentrade.

jonn4y avatar jonn4y commented on July 17, 2024

@TheRealHotSwap

thats a SQL error
if you read the line it says WHERE id=undefined
so its not passing the userID to the query, this particular SQL query is called multiple times in multiple files for different reasons so its a little hard to locate whats happening without seeing more of your debug.

from opentrade.

 avatar commented on July 17, 2024

@jonn4y Would you still be able to take a look at this error?

from opentrade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.