Giter VIP home page Giter VIP logo

Comments (5)

andrewdavidmackenzie avatar andrewdavidmackenzie commented on September 17, 2024

Well, I'd say it's a "common" way to do it - like it's assuming form-urlencoded .... arguably it should depend on the content type and use the body or not, depending on that?

from apicast.

mayorova avatar mayorova commented on September 17, 2024

arguably it should depend on the content type and use the body or not, depending on that?

Yes, probably this makes sense.

But then for requests like:

curl -XPOST "http://localhost:8080/test?key=hello" -H "Content-Type: application/json" -d '{"another":"parameter"}'

What would be the behavior? Should the request match or not the 2nd mapping rule?

from apicast.

andrewdavidmackenzie avatar andrewdavidmackenzie commented on September 17, 2024

I would say it would, as the URL+query parameters match the rule.

I'd consider the current behavior dubious - we need to understand if customers rely on this and "fixing it" would be a breaking change.

e.g. if content-type is form-url-encoded then match the rule against the URL plus the parameters in the body....otherwise use the url parameters only

from apicast.

mikz avatar mikz commented on September 17, 2024

I agree. If content-type is form-url-encoded, merge the body with the url params. Otherwise url params only.

from apicast.

mikz avatar mikz commented on September 17, 2024

Just the authentication parameters got fixed. This still has to be done for mapping rules.

from apicast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.