Comments (5)
Well, I'd say it's a "common" way to do it - like it's assuming form-urlencoded .... arguably it should depend on the content type and use the body or not, depending on that?
from apicast.
arguably it should depend on the content type and use the body or not, depending on that?
Yes, probably this makes sense.
But then for requests like:
curl -XPOST "http://localhost:8080/test?key=hello" -H "Content-Type: application/json" -d '{"another":"parameter"}'
What would be the behavior? Should the request match or not the 2nd mapping rule?
from apicast.
I would say it would, as the URL+query parameters match the rule.
I'd consider the current behavior dubious - we need to understand if customers rely on this and "fixing it" would be a breaking change.
e.g. if content-type is form-url-encoded then match the rule against the URL plus the parameters in the body....otherwise use the url parameters only
from apicast.
I agree. If content-type is form-url-encoded, merge the body with the url params. Otherwise url params only.
from apicast.
Just the authentication parameters got fixed. This still has to be done for mapping rules.
from apicast.
Related Issues (20)
- backend.t HOT 1
- resolver.t HOT 2
- balancer.t HOT 1
- apicast-upstream-balancer.t
- management.t
- apicast-mapping-rules.t
- backend-cache-handler.t
- Review and update DNS-resolver doc HOT 5
- Setup local env fails HOT 13
- Retiring the probot-changelog app HOT 1
- Trigger Alert `CoreDNSErrorsHigh` with OpenShift 4.11.9 HOT 2
- Swagger compatibility Issue HOT 5
- Edge Limiting is sharing the hits across windows HOT 3
- GRPC integration tests HOT 1
- OpenTelemetry instrumentation does not use environment variable OTEL_RESOURCE_ATTRIBUTES HOT 1
- Need help with build failure on power HOT 2
- lua-rover issue faced while enabling support for power(ppc64le) architecture HOT 4
- Immediate, infinite recursion when configuration loader is set to `boot` and reloading is disabled HOT 2
- Keycloak roles and services under roles HOT 1
- Make prove command failing while enabling support for power(ppc64le) architecture. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apicast.