require-listener-teardown not warning about eslint-plugin-wc HOT 7 CLOSED

Thanks @stramel for the clue. I'll try that route and see if I can get that up

from eslint-plugin-wc.

can you give more info on how you tested it and where it didn't work, that you expected it would?

from eslint-plugin-wc.

can you give more info on how you tested it and where it didn't work, that you expected it would?

I tried it in Atom, and via CLI. The code I used was the example provided in your doc.

• Is the rule working for you?
• Is a specific version of Node required for that rule?

from eslint-plugin-wc.

Yes of course, we have tests which assert this too and currently pass fine. It would be very helpful if you could paste the code you expect to cause an error, even if it is like in the docs.

I'll try it again myself when I get some spare time. Apologises for the slow response too.

from eslint-plugin-wc.

I troubleshooted this a bit and noticed that a couple of rules listed on the current README have not been correctly added to the rules export here:
https://github.com/43081j/eslint-plugin-wc/blob/master/src/index.ts#L11-L19

It's missing require-listener-teardown and no-constructor-params. That's probably why this isn't working as intended.

I can try putting up a PR to help fix this.

from eslint-plugin-wc.

Er, looks like I don't have permissions to push upstream or set up a new PR. @43081j I have a commit that fixes this. Any access to put up a PR?

from eslint-plugin-wc.

@dannobytes You will need to fork the repository and submit a PR from your fork to the main branch.

from eslint-plugin-wc.