style: enforece cpp style convention in hybridse about openmldb HOT 6 CLOSED

https://google.github.io/styleguide/cppguide.html#Function_Names

Accessors and mutators (get and set functions) may be named like variables. These often correspond to actual member variables, but this is not required. For example, int count() and void set_count(int count).

from openmldb.

Not only EngineOptions, many SQLNodes and PhysicalOpNodes have this kind of getter and setter style

from openmldb.

Is there any doc about the local test related to EngineOptions, SQLNode, PhysicalNode to verify it work correctly after change the style to google cpp style ? Like, for example, toydb_engine_test.cc, it is a test which used EngineOptions, I want to check whether it work correctly, but I'm not clear how to test it locally . Or is there a test framework to verify the commit code? Thanks for your reply!

from openmldb.

Is there any doc about the local test related to EngineOptions, SQLNode, PhysicalNode to verify it work correctly after change the style to google cpp style ? Like, for example, toydb_engine_test.cc, it is a test which used EngineOptions, I want to check whether it work correctly, but I'm not clear how to test it locally . Or is there a test framework to verify the commit code? Thanks for your reply!

Thanks @FrankSzn . You can compile and test plan and engine locally by the following steps:

1. setup the env: install third-party and create symbol link. Check setup_thirdparty.sh.
2. compile & test (check hybridse_core_test).

> cd YOUR_PROJECT_ROOT/OpenMLDB/hybridse/
> mkdir build && cd build
> cmake .. 
> make 
> SQL_CASE_BASE_DIR=YOUR_PROJECT_ROOT/OpenMLDB make test

If you just want to run spefic test file (e.g., toydb_engine_test), find the path of the test and run it.

> cd YOUR_PROJECT_ROOT/OpenMLDB/
> cd hybridse/build

> SQL_CASE_BASE_DIR=YOUR_PROJECT_ROOT/OpenMLDB ./example/toydb/src/testing/toydb_engine_test

Hope this answer can help. :)

from openmldb.

Thanks for your clear guide!

from openmldb.

similar issues https://github.com/4paradigm/OpenMLDB/pull/609/files#r740130601

from openmldb.