Flutter Analyze about openflutterecommerceapp HOT 5 CLOSED

Hello!
Seems like you run a bit outdated version of the code. The most recent version is in the development branch. Recently we switched branches to make it work on stable instead of beta. Please switch to the development branch and try to run it with flutter channel stable.

from openflutterecommerceapp.

Hello!
Seems like you run a bit outdated version of the code. The most recent version is in the development branch. Recently we switched branches to make it work on stable instead of beta. Please switch to the development branch and try to run it with flutter channel stable.

@Yahhi : I switched to the stable channel and development branch, and see the following issues. I think README says that there shouldn't be any issues to start with.

 flutter analyze
Analyzing openflutterecommerceapp...                                    

   info • Unused import: 'package:equatable/equatable.dart' • lib/data/error/exceptions.dart:1:8 • unused_import
   info • Use collection literals when possible • lib/data/woocommerce/repositories/category_remote_repository.dart:22:35 •
          prefer_collection_literals
   info • The method doesn't override an inherited method • lib/data/woocommerce/repositories/category_remote_repository.dart:35:20 •
          override_on_non_overriding_member
   info • Unused import: 'package:openflutterecommerce/domain/usecases/base_use_case.dart' •
          lib/domain/usecases/products/find_products_by_filter_use_case_impl.dart:3:8 • unused_import
   info • This function has a return type of 'Future<ProductsByFilterResult>', but doesn't end with a return statement •
          lib/domain/usecases/products/find_products_by_filter_use_case_impl.dart:16:34 • missing_return
   info • The value of the local variable 'productCategories' isn't used •
          test/data/woocommerce/repositories/category_remote_repository_test.dart:23:9 • unused_local_variable

6 issues found. (ran in 7.9s)

from openflutterecommerceapp.

Another question: Which branch should I be making pull requests to? master or development?

from openflutterecommerceapp.

Another question: Which branch should I be making pull requests to? master or development?

Development. In this branch, there are all most recent changes. When it comes to a finished feature or important change we merge it with master.

And regarding issues - possibly the most recent changes @4seer made in this branch were not checked with analyze. You can fix them! Feel free to fix them and make a PR

from openflutterecommerceapp.

Should be ok now.

from openflutterecommerceapp.