Comments (7)
collapsedDrawerHeight = partialRevealDrawerHeight
This is not a supported setting.
There is math that relies on these numbers not being the same. If you don't need separate positions for collapsed and partial reveal, then use a supportedDrawerPositions array that omits the partial reveal position.
supportedDrawerPositions = PulleyPosition.all
This configuration also includes the 'closed' drawer mode, which will position it lower (likely offscreen, depending on the way it's setup). This could also play into the issue you're seeing.
from pulley.
I have tried
collapsed position = X
partialRevealDrawerHeight = X + 1
supportedDrawerPositions = [PulleyPosition.collapsed,PulleyPosition.open]
and I still see the problem.
I have added a short video to show it:
https://youtu.be/RmiaGqME4SM
I also notice that the slider doesn't snap to the extremeties. I don't know if that is normal, from looking at the code, it looks like when you slide the drawer in one direction it should snap to the closest extremity, and it doesn't do that.
*Note, I am not using a TabController. I am using a tabbar on a normal UIViewController, so they have no interaction, one is simply on top of the other. I set the collapsed slider position to be 49 * 2.3 (49 is the size of the tabbar) so it can show.
from pulley.
Can you test the code compiled against the iOS 10 SDK, running in an iOS 10 simulator? That looks like iOS 11, which has changed a lot of how layout guides and margins work. Pulley isn't currently ready to be built with the iOS 11 SDK.
from pulley.
If it still happens on iOS 10, please provide a sample project and I'll see if I can figure out what it's doing and/or how to work around it.
from pulley.
I deployed on iOS 10.3 and yes, it works in that it doesn't go all the way to the bottom now. Thanks!
Something else I noticed, even on 10.3, is that I am able to move the drawer from the mainContentVC.
So even though I am not touching the drawer I am able to move it up and down, and I can't move the tableView cells on the mainContentVC.
I'm not sure what I am doing wrong.
from pulley.
Good to hear it works properly (regarding the bottom) on 10.3 for you.
Try the demo project and see if there are any significant differences in your implementation. The demo project has a scrollable map behind it, and it scrolls without affecting the drawer. A tableview, etc. should scroll normally behind the drawer.
from pulley.
Alright, so I see it doesn't like having the pulleycontroller not be the root view controller.
Setting it as root and it works, but now I need to add the tabbar into that view.
I subclassed PulleyViewController.swift added the tabbar and it works flawlessly. (Just in case anyone else would like to use a tabbar, it's possible.)
from pulley.
Related Issues (20)
- Pulley hangs on xcode 12 ios 14. HOT 2
- iOS 13 feedback loop with latest release 2.8.3 HOT 10
- Unable to drag the drawer on iOS 14 HOT 5
- Animation HOT 4
- [QUESTION] Help with error: "When instantiating from Interface Builder you must provide container views with an embedded view controller. HOT 1
- App getting hang on iOS 14 using pulley HOT 1
- Navigator BAr
- Remove possibly unnecessary view
- [BUG] iPad panel mode problem HOT 1
- [BUG] The latest version Pulley 2.9.0 does not start PulleyViewController HOT 1
- [QUESTION] How to resize the content of the drawer as it is opened and closed HOT 1
- [BUG] There is a 20 pixel top inset for the PulleyPassThroughScrollView which doesn't accept user action HOT 3
- Is there any way to apply corner radius to only one side? HOT 2
- Open other controller within Drawer
- [QUESTION] Update bounceOverflowMargin HOT 1
- Pulley drawer dimming view appears after UINavigationViewController push new viewController
- [QUESTION] How to control bounce of pulley when it is used in UITabBarController
- Strange lines on mac catalyst 16
- Trying to instantiateViewController to open the pulley view controller
- I hope there are more convenient functions, such as the function of directly displaying the QR code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pulley.