Giter VIP home page Giter VIP logo

Comments (4)

lukasschor avatar lukasschor commented on August 23, 2024 1

Oh, I guess I wanted to say -> ... and change text to : "Any transaction requires the confirmation of:"

Because it current mentiones the daily limit, whereas the daily limit is not yet implemented.

from safe-react.

germartinez avatar germartinez commented on August 23, 2024

@lukasschor

Show State

I assume we do this with notifications #135

Confirm name change

There are no designs for this. Is it a different page or just a notification in the bottom right corner?
What would be the exact text to show?

Owners: Remove pagination

Anything else apart from pagination? :)

Threshold: Change text

Sorry, I don't understand this point

Consistent height of settings options

Totally makes sense for screens with height smaller than the default, just to mention that if we remove pagination from the owner list, this page could have a bigger height.

from safe-react.

lukasschor avatar lukasschor commented on August 23, 2024

I assume we do this with notifications #135

Yes, added more info in the spec

There are no designs for this. Is it a different page or just a notification in the bottom right corner?
What would be the exact text to show?

Yes, added more info in the spec

Anything else apart from pagination? :)

Sorry, I don't understand this question. :P

Sorry, I don't understand this point

In the "Name Settings" the text takes the entire width of the card, in the "Threshold settings" there is a line-break roughly in the middle of the card. This should be removed and the text should basically just be one line.

Totally makes sense for screens with height smaller than the default, just to mention that if we remove pagination from the owner list, this page could have a bigger height.

Yes, I think that's fine 👍

from safe-react.

germartinez avatar germartinez commented on August 23, 2024

Sorry, I don't understand this question. :P

This is the text below the title Owners: Remove pagination:
"Remove pagination and"
I just thought that maybe there was something else that was accidentally deleted

In the "Name Settings" the text takes the entire width of the card, in the "Threshold settings" there is a line-break roughly in the middle of the card. This should be removed and the text should basically just be one line

Thanks 👍

from safe-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.