Comments (12)
I merged changes after user tests, address book and incoming transactions on zeplin: https://zpl.io/a7Ee5m8 (except for one question about icon for custom transactions)
from safe-react.
Rebranding is up for review: https://invis.io/C8TFLRFU4ZV
from safe-react.
This screen is outdated (not needed): https://projects.invisionapp.com/share/C8TFLRFU4ZV#/screens/378759100
Is value
in this screen the value for a single token or the value for the token balance? https://projects.invisionapp.com/share/C8TFLRFU4ZV#/screens/378759307
If we make the Safe for Teams compatible with Mainnet, will the network
value use the same orange circle as Rinkeby here? https://projects.invisionapp.com/share/C8TFLRFU4ZV#/screens/378758900
from safe-react.
Changes are up for review: https://invis.io/C8TFLRFU4ZV
What's been done: improvements from https://github.com/gnosis/safe-react/milestone/2?closed=1 and https://github.com/gnosis/safe-react/milestone/3.
This screen is outdated (not needed):
@germartinez This screen is updated
Is value in this screen the value for a single token or the value for the token balance?
Not for single token
If we make the Safe for Teams compatible with Mainnet, will the network value use the
same orange circle as Rinkeby here?
We can take the color from metamask
from safe-react.
Some small changed after comments on Invision: https://invis.io/C8TFLRFU4ZV
from safe-react.
Proposed changes after user tests
Problems we have:
- status of transaction is not clear (confirmed or executed).
- there is no indication when you have to confirm a transaction submitted by another owner.
The problem could be solved by showing notification when confirmation is required:
Clicking on it could open tx details. One way to show the status of transaction more clearly is to get rid of the tabs (confirmed/unconfirmed) and show the actions in the order in which they came. Each action has its own progress bar.
-
Tx executed:
It is important that "Confirm" button shows against your address so you know which one is you. The statuses in the list could be more specific: "Awaiting your confirmation", "Awaiting execution", "Executed".
The second option is to show it in the form of timeline, every action has a vertical progress bar.
from safe-react.
I really like the suggestions. I think they help understand better what actions are needed to actually execute a transaction. I prefer the second option with the timeline, but would maybe slightly simplify it.
I would rename "CONFIRM" to "TO CONFIRM" and remove the numbers behind that, so it only show the threshold after "CONFIRMED".
Especially, as we will move to off-chain signatures, having a progress bar for each owner does not make that much sense. Instead of individual segments, I would just make one line between the categories. And maybe in the circle besides "TO CONFIRM" a clock or hourglass symbol on a grey background.
What do you think?
from safe-react.
@lukasschor So we have these states:
I don't agree with removing numbers after "TO CONFIRM", I think it's passing the responsibility of doing math onto the users.
from safe-react.
I don't agree with removing numbers after "TO CONFIRM", I think it's passing the responsibility of doing math onto the users.
I like the new timeline style. I think we can simplify this even further by completely leaving out the "TO CONFIRM" section and just alway show the structure used in the designs at the bottom. (just two sections CONFIRMED and EXECUTE TX with the ones confirmed being filled and the others non-filled circles). What do you think?
So far there is no state "No one confirmed" as by creating a transaction one does already make the first confirmation.
Also, does it make sense to show the execute button always under the EXECUTE TX section, and show owner address on the left? So show this:
also like this:
from safe-react.
@lukasschor Corrected
from safe-react.
Looks very good.
Just to clarify, the number after "CONFIRMED" should be number of collected confirmations / threshold? In that case the two lower designs should be changed to say (3/3) instead of (3/5) not to cause confusion during implementation.
from safe-react.
@lukasschor Yes this should be "collected confirmations/threshold".
from safe-react.
Related Issues (20)
- highlighting paused state of the safe token contract in the asset list HOT 1
- Signing with Ledger on Avalanche not working
- Add more tests for the safe apps signing feature
- Safe Ledger support on Aurora HOT 3
- [Desktop app] Invalid JSON RPC response: "project id required in the url" HOT 3
- EIP-712 signing not working HOT 1
- Create a new safe when already having a safe HOT 3
- Ledger not connecting after update HOT 1
- Optimism: creating a Safe – gas limit < 21000 HOT 1
- Enable Optimism support for Tally Ho HOT 5
- Error: A "infuraKey" or a "rpc" object with a parameter of 4 must be included in the WalletConnect initialization object HOT 2
- Allow DELEGATECALL as a UI option
- Gnosis safe transaction stuck HOT 1
- txStatus Cancelled HOT 4
- Enable Arbitrum support for Tally Ho on Safe HOT 3
- custom deployed safe not found HOT 3
- missing builds since 3.22.1 HOT 3
- Allow empty string to be passed HOT 2
- Sepolia Testnet Version HOT 6
- Always indexing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-react.