primS Telnet Client Performance about telnet HOT 11 CLOSED

Thanks for the quick reply. I have a deep embedded programming experience so could follow the code to the place, but I'm not experienced in Windows to specifically understand the nuances (delay vs. sleep etc.). I'll try to get deeper in and hope I can make it. Just to understand the reasoning - what are the pros of the current design (for which we "pay" in the high CPU? Where's the trade off? Thanks again, I

Many many thanks, We certainly could overload functions and rebuild as necessary but would be happy if you could point me better. Generally, would you think it is better to merge this (as configurable option or otherwise) into the main branch, or leave it as a proprietary/private case in my specific case? I On 9 May 2018, at 1:50, 9swampy <[email protected]<mailto:[email protected]>> wrote: Sorry for misleading, you're right. I checked out the code while merging in the LineTerminator PR and seems like you would need a code change to alter the DefaultTimeoutMs. Wouldn't be too hard to add in an overload or two (or more for others with same problem :) and would definitely be a step in the right direction even if it would still be a bit of a sledgehammer... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F9swampy%2FTelnet%2Fissues%2F27%23issuecomment-387567050&data=02%7C01%7C%7Cf6ec4a15737348bf914708d5b5362470%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636614166500418094&sdata=uZTREepSazlfhb475mxVvtqsbscYUVVsYIJpkxMN8tQ%3D&reserved=0>, or mute the thread<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkwSAbGO-KmB2tag9l2Fh20jVBlz-1jzks5twiFIgaJpZM4T0DnN&data=02%7C01%7C%7Cf6ec4a15737348bf914708d5b5362470%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636614166500574345&sdata=JCxMc8OWFBN9dYufhVLsS1yBLl%2FvtfytnSJtyAQWDWI%3D&reserved=0>.

Check out the GitFlow structure: Create a feature branch off Develop and when we know the scope of the fix we can assess whether/how to merge in so other users with the same issue can benefit without affecting those that hadn't been affected... From: iftahb Sent: Wednesday, 9 May 2018 05:35 To: 9swampy/Telnet Reply To: 9swampy/Telnet Cc: 9swampy; Comment Subject: Re: [9swampy/Telnet] primS Telnet Client Performance (#27) Many many thanks, We certainly could overload functions and rebuild as necessary but would be happy if you could point me better. Generally, would you think it is better to merge this (as configurable option or otherwise) into the main branch, or leave it as a proprietary/private case in my specific case? I On 9 May 2018, at 1:50, 9swampy <[email protected]<mailto:[email protected]>> wrote: Sorry for misleading, you're right. I checked out the code while merging in the LineTerminator PR and seems like you would need a code change to alter the DefaultTimeoutMs. Wouldn't be too hard to add in an overload or two (or more for others with same problem :) and would definitely be a step in the right direction even if it would still be a bit of a sledgehammer... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F9swampy%2FTelnet%2Fissues%2F27%23issuecomment-387567050&data=02%7C01%7C%7Cf6ec4a15737348bf914708d5b5362470%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636614166500418094&sdata=uZTREepSazlfhb475mxVvtqsbscYUVVsYIJpkxMN8tQ%3D&reserved=0>, or mute the thread<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkwSAbGO-KmB2tag9l2Fh20jVBlz-1jzks5twiFIgaJpZM4T0DnN&data=02%7C01%7C%7Cf6ec4a15737348bf914708d5b5362470%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636614166500574345&sdata=JCxMc8OWFBN9dYufhVLsS1yBLl%2FvtfytnSJtyAQWDWI%3D&reserved=0>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#27 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAf7LunFr6Nw632taDa48mLBLNuO4F1Jks5twnIOgaJpZM4T0DnN>. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/9swampy/Telnet","title":"9swampy/Telnet","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/9swampy/Telnet"}},"updates":{"snippets":[{"icon":"PERSON","message":"@iftahb in #27: Many many thanks,\r\n\r\nWe certainly could overload functions and rebuild as necessary but would be happy if you could point me better.\r\nGenerally, would you think it is better to merge this (as configurable option or otherwise) into the main branch, or leave it as a proprietary/private case in my specific case?\r\n\r\nI\r\n\r\n\r\n\r\nOn 9 May 2018, at 1:50, 9swampy \[email protected]\u003cmailto:[email protected]\u003e\u003e wrote:\r\n\r\n\r\nSorry for misleading, you're right. I checked out the code while merging in the LineTerminator PR and seems like you would need a code change to alter the DefaultTimeoutMs. Wouldn't be too hard to add in an overload or two (or more for others with same problem :) and would definitely be a step in the right direction even if it would still be a bit of a sledgehammer...\r\n\r\n—\r\nYou are receiving this because you authored the thread.\r\nReply to this email directly, view it on GitHub\u003chttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F9swampy%2FTelnet%2Fissues%2F27%23issuecomment-387567050\u0026data=02%7C01%7C%7Cf6ec4a15737348bf914708d5b5362470%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636614166500418094\u0026sdata=uZTREepSazlfhb475mxVvtqsbscYUVVsYIJpkxMN8tQ%3D\u0026reserved=0\u003e, or mute the thread\u003chttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkwSAbGO-KmB2tag9l2Fh20jVBlz-1jzks5twiFIgaJpZM4T0DnN\u0026data=02%7C01%7C%7Cf6ec4a15737348bf914708d5b5362470%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636614166500574345\u0026sdata=JCxMc8OWFBN9dYufhVLsS1yBLl%2FvtfytnSJtyAQWDWI%3D\u0026reserved=0\u003e.\r\n"}],"action":{"name":"View Issue","url":"#27 (comment)"}}} {"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [9swampy/Telnet] primS Telnet Client Performance (#27)","sections":[{"text":"","activityTitle":"**iftahb**","activityImage":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","activitySubtitle":"@iftahb","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"9swampy/Telnet\",\"issueId\":27,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close issue","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueClose\",\"repositoryFullName\":\"9swampy/Telnet\",\"issueId\":27}"},{"targets":[{"os":"default","uri":"https://github.com/9swampy/Telnet/issues/27#issuecomment-387617403"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":332413389}"}],"themeColor":"26292E"} -- This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of PrimS Ltd. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Spam.<http://esva2.prims.local:8015/cgi-bin/learn-spam.cgi?id=CBF0329187.38B7E> Ham.<http://esva2.prims.local:8015/cgi-bin/learn-ham.cgi?id=CBF0329187.38B7E>

Many many thanks and we greatly appreciate this. I will certainly test. In my scenario we hardly “transmit”, but usually receive big chunks of data. Do yo think they the new fix would be useful? We run in 10 concurrent threads and therefore see CPU load extremely high. Kind regards, I