git does not build on arch - 6.4.1-arch2-1 implicit declaration of function ‘register_sysctl_paths’; did you mean ‘register_sysctl_table’? [-Werror=implicit-function-declaration] about ipt-netflow HOT 9 OPEN

Hi,

Try this: https://github.com/kalamlacki/ipt-netflow

from ipt-netflow.

Try this: https://github.com/kalamlacki/ipt-netflow

"Update ipt_NETFLOW.c" is a very bad style for commit messages. 😞 Please put the relevant part like "update for >= 6.4.0" into the first line of the commit message.

The relevant commit for this issue seems to be kalamlacki@2a1d250

Thanks for the patch anyways, even if we had to check all commits to find the relevant one. 😃

from ipt-netflow.

I have one remark, you should take my last 2 commits not only one, the path for sysctl should be net/netflow and not net.netflow

from ipt-netflow.

I have one remark, you should take my last 2 commits not only one, the path for sysctl should be net/netflow and not net.netflow

Thanks, will have look at that, too. (Currently trying to fix this compilation issue for ipt_NETFLOW in Debian Unstable.)

from ipt-netflow.

When you use net/netflow then command

sysctl net.netflow

looks like on older kernel without this issue

from ipt-netflow.

Relevant commit in Linux seems to be torvalds/linux@0199849.

from ipt-netflow.

I have one remark, you should take my last 2 commits not only one, the path for sysctl should be net/netflow and not net.netflow

Indeed, it compiles fine without, but when actually running kernel 6.4 without it, sysctl -a, will throw errors like these:

sysctl: cannot stat /proc/sys/net/netflow.active_timeout: No such file or directory
sysctl: cannot stat /proc/sys/net/netflow.debug: No such file or directory
sysctl: cannot stat /proc/sys/net/netflow.destination: No such file or directory
[…]

from ipt-netflow.

You were testing the commit with net.netflow right? When I test the version with net/netflow I get correct result with sysctl.
I checked the path to version 6.4.0 and everywhere when was register_sysctl_paths() was renamed on to register_sysctl()

from ipt-netflow.

You were testing the commit with net.netflow right?

Yes, I wanted to understand why a slash instead of the expected dot was necessary.

from ipt-netflow.