Comments (6)
I haven't used the bind
method, but it sounds to me like the behavior is incorrect. If that's the case, I don't think we need a new method, we should just fix the existing one.
Also, what's the benefit of the marker interface in this case over a plain Object?
from sql2o.
Also, what's the benefit of the marker interface in this case over a plain Object?
if (obj instanceof ParamObject){
// analyze fields and put them as param values
} else {
// analyze getXXXX methods (bean-style) and put them as param values
}
from sql2o.
The inheritance issue should be fixed. It is also described in issue #55.
When binding objects, we should only bind expected parameters. So if we have 2 parameters in the sql-statement, but 3 properties on the binded object, it should only bind the 2 parameters and ignore the last property. It seems like this behavior has been changed recently from the original implementation of bind(). as @dimzon points out, it will throw exception if this happens today! This should be fixed.
Given the above, I don't think the changes suggested will break backwards-compatibility?
If we add analysis of fields (in addion to getters), we don't need the ParamObject interface. Then it should work with:
executeQuery("select @name, @age", new Object(){
int age = 31;
String name = "dimzon!"
})
as well as with:
executeQuery("select @name, @age", myPojo)
from sql2o.
who will do this (I can but if anyone else want feel free to stop me)
from sql2o.
@dimzon - Your on a killing spree :)
Go ahead. I'm really glad that sql2o gets the love it deserves.
BTW, you deserve your name under developers in the pom.xml file (If you would like it there, of cause - no pressure :) You have been a really valuable contributor! Without you and @aldenquimby, sql2o would never have been able to become such an awesome project!
from sql2o.
btw - When fixing an issue like this. I would recommend creating a new branch just needed for the fix.
git branch fix-issue-80
git checkout fix-issue-80
Do your stuff, and check it in with a commentary that mensions the issue number, like this: "ref #80 - comment here".
when you are done:
git push -u origin fix-issue-80 // -u sets upstream to origin/fix-issue-80, so that the next time you push on the same branch, you can just write "git push"
On github, create a pull request from the new branch.
This way you can start on working on other things, and not have to wait for me to merge in your work.
from sql2o.
Related Issues (20)
- Issue with ArrayParameters.updateQueryWithArrayParameters when query contains '?' character
- When in jar file I receive No suitable driver for error HOT 1
- Publish version 1.6.0 of oracle extensions
- sql2o can't rolback ? HOT 3
- can i change the Type of return value of executeAndFetch()
- State of the Project
- NPE when return query object is of type Map HOT 1
- How to correctly insert with array type (ex bigint[]) columns?
- Library uses now-private reflection mechanism HOT 2
- Can't add ON DELETE CASCADE to forein key when creating table, using PostgreSQL. HOT 1
- Updated MySQL 8.0.26 connector breaks historically working code HOT 2
- Next release HOT 2
- MethodSetter setProperty failing with generic IllegalArgumentException
- Failed test testAllTypes(org.sql2o.reflect.ReflectionFieldSetterFactoryTest) only in Maven HOT 2
- Collection of enums is not properly mapped to query params HOT 1
- SQL2o 1.6.0 Compatabile with JDK 17/ OpenJDK 17 ? HOT 1
- SQL with ? for parameters HOT 4
- Retrieving List<Long> from query HOT 2
- Query.withParams upgrade HOT 2
- Javadoc has an issue with the CDN HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sql2o.