Suggestion: Remove input related functions from Saml2User about laravel-saml2 HOT 2 CLOSED

Single responsibility is a long thread... a good principle to follow, but it also depends on the level of abstraction... ie. I could make a single class called 'laravel-saml2' which has a single responsibility at that level.
For our case, maintainability is not an issue. We can always refactor later when we know what to extend... and API is 'simple' now. Now the user is like our most important 'api'. It's not a 'user', but it's a thing which gives you a very simple interface to saml with 4 methods. If we move that logic into the controller it will be harder to share with our users, and/or we need to introduce new entities (which add complexity).

from laravel-saml2.

I agree completely with not adding extra complexity, which is why I thought we could just move the two functions which are concerned with the request input onto the Saml2LoginEvent (and inject the request into it alongside the user object). That way the code consuming the event still gets access to the same functions, just a couple of them move to the other object.

I might make the change and send the pull request just so you can see what I mean, but feel free to ignore it, it's your library after all (and it is quite a fussy change tbh).

from laravel-saml2.