Comments (5)
I think a PR for that would be nice (I cant test the code myself right now). We could just expose the hole object just in case... getOneLoginSaml2Auth()
that returns auth?
from laravel-saml2.
That is a good suggestion!
Another idea would be to have Saml2Auth extend OneLogin_Saml2_Auth, then Saml2Auth would have access to the public methods in OneLogin_Saml2_Auth (Also meaning you could remove Saml2Auth->isAuthenticated(), Saml2Auth->login() and Saml2Auth->logout()) . Can you see any issues with this inheritance?
from laravel-saml2.
Inheritance adds a little more of coupling.. if onelogin changes their api in the future, we change our implementation and our users will be safe.
I didnt expose the raw object initially to have a clean API and easy to use for regular users, but I understand that for some advanced cases is needed... Its not clean, but its needed.. I would just expose the object for advanced usage and leave the rest of the api like it is.
from laravel-saml2.
Hi @aacotroneo, I try to maintain the API methods of php-saml intact, but sometimes new functionalities require adding new parameters or implement new methods.
For new releases, I will try to document what API methods changed so will be easy for you to update your part.
Best regards.
from laravel-saml2.
hi @pitbulk, I know that, I was just commenting a general idea about inheritance over composition, your API has been very stable for sure.. we barely had to change anything because of a breaking change here
BTW, very nice library you've made!
Cheers!
from laravel-saml2.
Related Issues (20)
- Laravel authenticated tests, phpunit
- [Question] How to handle multi-tenancy? HOT 1
- Update php-saml dependency to accept php-saml 4.X version (compatible with php 8.X)
- Trying to use with Laravel 5.6.46 and PHP 7.4 HOT 1
- No facade any more? HOT 1
- How can i use logout salm2auth
- Swoole exit() triggered using Laravel Octane & Swoole HOT 2
- Auth::login($user) doesn't persist when I go to the homepage. HOT 1
- Handle the situation when a user doesn't exists
- Does this package deal with x509certNew
- Error local.ERROR: DOMDocument::loadXML(): HOT 1
- ADFS on premises with Laravel App and generation of Metafile
- Is this project dead? HOT 4
- ADFS IDP checking if user already logged in via middleware or anyother way
- Log warning ยท Function openssl_x509_free() is deprecated
- google sso 403
- Reference validation failed Redirecting to https://... HOT 8
- Support Laravel 11 HOT 1
- getMetaData adds empty new lines
- getMetaData adds empty new lines
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-saml2.