Giter VIP home page Giter VIP logo

Comments (4)

aacotroneo avatar aacotroneo commented on June 24, 2024

yep, that could be a good improvement. It's not supported because no one needed/cared about it, but it does make sense. Something like this to remain the most backwards compatible we can?

 if (!empty($config['sp']['singleLogoutService']) && 
     empty($config['sp']['singleLogoutService']['url']){
            $config['sp']['singleLogoutService']['url'] = URL::route('saml_sls');
 }

from laravel-saml2.

JoeyHoutenbos avatar JoeyHoutenbos commented on June 24, 2024

I agree with you that would be the most backwards compatible solution.
This means in the settings the whole singleLogoutService part can be removed and it won't be added to the metadata.

Is this something you can include soon?

from laravel-saml2.

aacotroneo avatar aacotroneo commented on June 24, 2024

from laravel-saml2.

JoeyHoutenbos avatar JoeyHoutenbos commented on June 24, 2024

I made a PR #69. Please check it out and include in next release.

from laravel-saml2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.