StaFact facts breaks the concurrency limitations of Xunit about xunit.stafact HOT 11 CLOSED

We found another issue... :(
Please wait with the release.

from xunit.stafact.

We occasionally see our tests fails or even hang on our build servers which is mentioned in one of those threads. Have you seen this as well?

from xunit.stafact.

Yes, they have been failed if they rely on timing (assertion of execution time).
They did NOT hang, at least we haven't noticed that so far.

from xunit.stafact.

Thanks for reporting. Any idea how we would fix this? I have no experience with the xunit parallel execution throttle. The xunit methods are mostly async, so it seems designed that tests not always block a thread, so if xunit's throttling assumes the test blocks a thread, that already seems broken without UIFact's help. Can you repro this problem with any [Fact]-based async Task returning method that yields right away with .ConfigureAwait(false)?

from xunit.stafact.

I think it should be ok to block the xunit thread while UIFact thread (and all other thread in this extension) is executing. Synchronous thread will "block" the thread too.
Let say, the UIFact thread replaces temporary the xunit thread.

Can you repro this problem with any [Fact]-based async Task returning method that yields right away with ConfigureAwait(false)?

I could not really understand your question.
And, what is the background of this question?

from xunit.stafact.

what is the background of this question?

I am trying to establish how xunit throttles test runs when tests are asynchronous. Because whatever that mechanism is, we should reuse it for UIFact.

from xunit.stafact.

Xunit starts as many threads as tests should be in parallel. All testing work is distributed to these worker threads.

With the additional threads of StaFact the mechanism cannot be reused, I guess.
Instead I think the the Xunit thread should be blocked while StaFact thread is running.

Maybe @xunit can help?

from xunit.stafact.

@AArnott , when do you plan to create a new release with this issue fixed?

from xunit.stafact.

I'll try to get it out later today.

from xunit.stafact.

This is now available as https://github.com/AArnott/Xunit.StaFact/releases/tag/v1.1.5-alpha

from xunit.stafact.

Hey @AArnott, could you please create a new public release?
I have a new project which must not use alpha or beta releases.

from xunit.stafact.