Comments (11)
We found another issue... :(
Please wait with the release.
from xunit.stafact.
We occasionally see our tests fails or even hang on our build servers which is mentioned in one of those threads. Have you seen this as well?
from xunit.stafact.
Yes, they have been failed if they rely on timing (assertion of execution time).
They did NOT hang, at least we haven't noticed that so far.
from xunit.stafact.
Thanks for reporting. Any idea how we would fix this? I have no experience with the xunit parallel execution throttle. The xunit methods are mostly async, so it seems designed that tests not always block a thread, so if xunit's throttling assumes the test blocks a thread, that already seems broken without UIFact's help. Can you repro this problem with any [Fact]
-based async Task
returning method that yields right away with .ConfigureAwait(false)
?
from xunit.stafact.
I think it should be ok to block the xunit thread while UIFact thread (and all other thread in this extension) is executing. Synchronous thread will "block" the thread too.
Let say, the UIFact thread replaces temporary the xunit thread.
Can you repro this problem with any
[Fact]
-basedasync Task
returning method that yields right away withConfigureAwait(false)
?
I could not really understand your question.
And, what is the background of this question?
from xunit.stafact.
what is the background of this question?
I am trying to establish how xunit throttles test runs when tests are asynchronous. Because whatever that mechanism is, we should reuse it for UIFact.
from xunit.stafact.
Xunit starts as many threads as tests should be in parallel. All testing work is distributed to these worker threads.
With the additional threads of StaFact the mechanism cannot be reused, I guess.
Instead I think the the Xunit thread should be blocked while StaFact thread is running.
Maybe @xunit can help?
from xunit.stafact.
@AArnott , when do you plan to create a new release with this issue fixed?
from xunit.stafact.
I'll try to get it out later today.
from xunit.stafact.
This is now available as https://github.com/AArnott/Xunit.StaFact/releases/tag/v1.1.5-alpha
from xunit.stafact.
Hey @AArnott, could you please create a new public release?
I have a new project which must not use alpha or beta releases.
from xunit.stafact.
Related Issues (20)
- Suggestion: Skip support (SkippableFact) HOT 4
- [StaFact] tests not found when used with netcoreapp2.2 HOT 13
- StaTheory is not supported in Visual Studio Runner HOT 13
- Support for OleInitialize HOT 2
- WPF support on .NET Core 3.0 breaks .NET Core 3.0 consumers on Linux/Mac
- Can't run tests HOT 2
- Generate test arguments on test thread
- CPU usage in polling message loop HOT 4
- Hanging UITheoryTestCase
- Clarify attribute names, or rename package ID HOT 8
- CollectionAttribute seems to be not respected HOT 7
- [StaFact] tests do not execute when targeting net462 HOT 8
- .net 4.5.2 compatibility HOT 3
- netstandard support HOT 1
- STA for Fixture Collections HOT 5
- Running all tests within a class on the same thread? HOT 12
- [MainThreadFact] to execute tests on main thread on macos HOT 6
- Custom Thread HOT 1
- WinUI Unit testing with UIFact doesn't appear to work. HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xunit.stafact.