Giter VIP home page Giter VIP logo

Comments (2)

aaugustin avatar aaugustin commented on May 19, 2024

If the HMAC that protects the token's integrity depends on the user's password, we must fetch the user from the database before we can validate the token. This leaks existence of user ids through a timing attack -- which might not be a very large concern if you're using this relatively insecure library, but I'm still uncomfortable with it.

I prefer to stick with the current design which includes two levels of hashing:

  • a HMAC managed by Django, which depends on SECRET_KEY, and ensures it isn't possible to forge a token; if a forged token is submitted, it fails the HMAC check, and that's it; nothing is leaked
  • a hash of the user's password, in order to invalidate tokens on password change.

from django-sesame.

aaugustin avatar aaugustin commented on May 19, 2024

I had forgotten about this ticket. I came up with the same idea 4 years later, made a different decision, and implemented it in #53.

from django-sesame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.