Limit number of portals buyable in one transaction about aavegotchi-contracts HOT 2 CLOSED

I set the maximum number of portals that can be purchased in one call to openPortals to 50.

However it is still possible to purchase more than 50 portals in a single transaction by calling openPortals multiple times within the same transaction.

But setting the maximum number of portals that can be purchased in one call to openPortals makes it harder to purchase more than that in a single transaction and increases the gas cost to do so and reduces the total number that can be purchased in a single transaction. The block gas limit determines the maximum number of portals that can be purchased in a single transaction.

Commit: 6eea94e

from aavegotchi-contracts.

Yes, I see what you mean. Someone very motivated to get all of the Portals in one block could spam multiple buyPortals transactions in the same block. But I think it's good to have the hard-coded limit nonetheless.

Closed for now.

from aavegotchi-contracts.