Hard node crash on MacOS Mojave about noble HOT 9 CLOSED

Why is your scanStart handler using this.log rather than console? this.log doesn't appear to exist.

from noble.

@mrstegeman you're right. That was a bad case of copy and paste from the actual implementation where I encountered this. I've fixed the example now, thanks!

(Note that this does not affect anything as that line is never run because of the crash).

Scratch that, looks like the this.log being undefined might be the cause of this anyway.

from noble.

So no crash anymore?

from noble.

No crash by using:

const noble = require("@abandonware/noble");
class Scanner {
  constructor() {
    noble.on("discover", this.onDiscover.bind(this));
    noble.on("scanStart", this.onScanStart.bind(this));
    noble.on("stateChange", () => {
      noble.startScanning([], true);
    });
  }

  onScanStart() {
    console.debug("Started scanning.");
  }

  onDiscover(peripheral) {
    console.log(peripheral);
  }
}
const scanner = new Scanner();

from noble.

Great! Can you go ahead and close?

from noble.

Si please close the issue if no more relevant

Eventually you can try to submit your example to upstream ?
That could be useful to have some CLI BLE utilities as part of package.

Relate-to: #9

from noble.

@mrstegeman thanks for the feedback.

from noble.

@hannseman Yes any exception thrown in the event handler will abort the node process.

from noble.

@geovie good to know, found the cause now in my actual implementation. Thanks for the help. I got a bit thrown of by the hard crash and missed the actual error message Cannot read property 'find' of undefined.

from noble.