Giter VIP home page Giter VIP logo

Comments (4)

dkle-1 avatar dkle-1 commented on September 21, 2024 1

Hi @sandraros,
sorry, we don't use git/github on a daily basis, therefore I am not able to create the pull request.
Best Regards
Daniel

from abap2xlsx.

sandraros avatar sandraros commented on September 21, 2024

Thank you. It's clear that comparing a string and a number is incorrect (1 should be changed into '1'). I didn't check, but adding 'true' to the test makes sense. The test with '1' should not be removed as the situation may still happen.

* issue #367 - hide columns from
IF ls_column-max = zcl_excel_common=>c_excel_sheet_max_col. " Max = very right column
IF ls_column-hidden = 1 " all hidden
AND ls_column-min > 0.
io_worksheet->zif_excel_sheet_properties~hide_columns_from = zcl_excel_common=>convert_column2alpha( ls_column-min ).

If possible, could you propose a pull request? Thank you.

from abap2xlsx.

sandraros avatar sandraros commented on September 21, 2024

No issue, thanks, I'll take care of it.

Reproduced. To reproduce:

  1. Run zdemo_excel37 to download or display the Excel file above.
  2. Short dump happens.

from abap2xlsx.

sandraros avatar sandraros commented on September 21, 2024

@ all , ignore the message above, it's an automatic absence message (in German)

from abap2xlsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.